support devfile 2.2.0, update the script and the library accordingly #88
Conversation
Signed-off-by: Stephanie <[email protected]>
Signed-off-by: Stephanie <[email protected]>
go.mod
Outdated
| @@ -3,7 +3,7 @@ module github.com/devfile/library | |||
| go 1.13 | |||
|
|
|||
| require ( | |||
| github.com/devfile/api/v2 v2.1.0 | |||
| github.com/devfile/api/v2 v2.0.0-20210527100059-8230c0835f1d | |||
There was a problem hiding this comment.
interestingly this is going back down one level? 🤔
There was a problem hiding this comment.
It's the version pulled from main branch. I would expect it's 2.1.0-<timestamp> as well.
Need to take a deeper look into api repo. But it shouldn't affect anything in library repo.
There was a problem hiding this comment.
Any updates on this before I approve the PR? why its 2.0.0..
There was a problem hiding this comment.
I asked John. He has no idea on why this version has not been updated to 2.1.0. but he said won't affect anything.
Also this should not be a common issue with importing devfile/api, not a library issue.
|
@maysunfaisal this PR is unblocked since #89 has been merged. can you help approve this PR? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maysunfaisal, yangcao77 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stephanie [email protected]
What does this PR do?
support devfile 2.2.0
update the script ./updateApi.sh to support devfile 2.2.0 as default, accept 2.1.0 as an arg to update 2.1.0
pull in latest schema change with project.Github removed for 2.1.0 & 2.2.0, and update library accordingly
What issues does this PR fix or reference?
Fixes devfile/api#471
Is your PR tested? Consider putting some instruction how to test your changes
updated unit tests