This repository was archived by the owner on Feb 1, 2021. It is now read-only.
Add cross-compilation to Travis #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(and it looks like Windows will be fixed in #205 👍) |
|
If you wanted to review and maybe even merge that, I'd be happy (of course) to rebase and retest. ❤️ |
|
|
||
| # https://github.com/docker/libcontainer/blob/e9f44b52de03138d9273eadd5a87a0cea11b4f5d/.travis.yml | ||
| env: | ||
| - TRAVIS_GLOBAL_WTF=1 |
There was a problem hiding this comment.
I thought it was for privileged containers, do we need this ?
There was a problem hiding this comment.
4:07 PM tianon: is the name TRAVIS_GLOBAL_WTF important ?
4:07 PM or can it be anything else ?
4:07 PM nope, it can be anything
4:08 PM that was just the name I came up with when frustrated that I couldn't just say "run these scripts outside the build matrix"
4:08 PM ok I see
Signed-off-by: Andrew "Tianon" Page <[email protected]>
Signed-off-by: Andrew "Tianon" Page <[email protected]>
|
Ok, rebased, added a bunch of comments, re-enabled windows, all green. 👍 |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #209 (comment), this excludes Windows for now (
api/server.go:29: undefined: syscall.Umask), and also excludes Go 1.4 for now (moovweb/gvm#116), but does include everything necessary to reenable them later without much fuss (once the issues with each are respectively resolved).