Fix "gvm cross" for Go 1.4 #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,11 +44,17 @@ export GOARCH=$1 | |||
| if [ ! -d "$GOROOT/pkg/${GOOS}_${GOARCH}" ]; then | |||
There was a problem hiding this comment.
I can't help but think that it might be more accurate here to look for "$GOROOT/pkg/${GOOS}_${GOARCH}/runtime.a" or similar, but I haven't done the necessary testing to verify that this would work across a reasonable number of Go versions (but it would catch attempted installs better, and make them easier to repeat).
It'd obviously need to come with the same logic above in display_list, so that's a project for a separate PR, IMO. :)
This was referenced Dec 24, 2014
|
This is affecting multiple Docker projects now (and I'd really rather avoid using |
|
hi @tianon sorry for the delay. could you rebase this on master? |
> go tool dist: opendir /home/user/.gvm/gos/go1.4/src/pkg/runtime: No such file or directory > ERROR: Couldn't compile runtime library for darwin amd64
|
Sure thing; rebased. |
|
thanks! |
gregorygtseng
added a commit
that referenced
this pull request
Feb 4, 2015
Fix "gvm cross" for Go 1.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also took the liberty of including a second commit which fixes some whitespace inconsistencies in the same file (but I'm happy to remove/separate that commit if preferred).