Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support to node 16 #2053

Closed
sibelius opened this issue Apr 21, 2021 · 1 comment · Fixed by #2055
Closed

add support to node 16 #2053

sibelius opened this issue Apr 21, 2021 · 1 comment · Fixed by #2055
Assignees
@trentm
Labels
agent-nodejs Make available for APM Agents project planning.

Comments

@sibelius
Copy link
Contributor

Is your feature request related to a problem? Please describe.
node 16 is out

Describe the solution you'd like
add node 16 in the valid engines

Describe alternatives you've considered
only adding 16 at engines will solve this

Additional context

[email protected]: The engine "node" is incompatible with this module. Expected version "^8.6.0 || 10 || 12 || 13 || 14". Got "16.0.0"
```

https://nodejs.medium.com/node-js-16-available-now-7f5099a97e70
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Apr 21, 2021
sibelius added a commit to sibelius/apm-agent-nodejs that referenced this issue Apr 21, 2021
@sibelius
feta(node): add suppport to node 16
2c7b806 
fix elastic#2053 2053
@sibelius sibelius mentioned this issue Apr 21, 2021
Closed
6 tasks
@trentm trentm self-assigned this Apr 21, 2021
trentm added a commit that referenced this issue Apr 21, 2021
@trentm
feat: support node 16; also test with node 15, drop testing of node 13
ce31964 
This borrows work from @kevcodez and myself on #1841.

Fixes: #2053
@trentm trentm mentioned this issue Apr 21, 2021
Merged
4 tasks
@trentm
Copy link
Member

trentm commented Apr 22, 2021

Closing as (now modified to include node v16) dupe of #1840

@trentm trentm closed this as completed Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trentm trentm

Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Milestone
No milestone
2 participants
@trentm @sibelius