Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feta(node): add suppport to node 16 #2054

Closed
wants to merge 1 commit into from
Closed

feta(node): add suppport to node 16 #2054

wants to merge 1 commit into from

Conversation

sibelius
Copy link
Contributor

@sibelius sibelius commented Apr 21, 2021 •
edited by zube bot
Loading

fix #2053

Checklist

  • Implement code
  • Add tests
  • Update TypeScript typings
  • Update documentation
  • Add CHANGELOG.asciidoc entry
  • Commit message follows commit guidelines

@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Apr 21, 2021
@apmmachine
Copy link
Contributor

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts

Expand to view the summary

Build stats

  • Build Cause: Pull request #2054 opened

  • Reason: The PR is not allowed to run in the CI yet

  • Start Time: 2021-04-21T12:01:20.760+0000

  • Duration: 3 min 55 sec

  • Commit: 2c7b806

Trends 🧪

Image of Build Times

Steps errors 2

Expand to view the steps failures

Load a resource file from a shared library
  • Took 0 min 0 sec . View more details on here
  • Description: approval-list/elastic/apm-agent-nodejs.yml
Error signal
  • Took 0 min 0 sec . View more details on here
  • Description: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)

Log output

Expand to view the last 100 lines of log output 

[2021-04-21T12:03:45.981Z] No valid HEAD. Skipping the resetting
[2021-04-21T12:03:45.981Z]  > git clean -fdx # timeout=10
[2021-04-21T12:03:46.002Z] Fetching upstream changes from [email protected]:elastic/apm-agent-nodejs.git
[2021-04-21T12:03:46.003Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-04-21T12:03:46.008Z]  > git fetch --no-tags --progress --prune -- [email protected]:elastic/apm-agent-nodejs.git +refs/pull/2054/head:refs/remotes/origin/PR-2054 +refs/heads/master:refs/remotes/origin/master # timeout=15
[2021-04-21T12:03:46.665Z] Merging remotes/origin/master commit b588a8854db46ed90a8f7e1189b52df5c40d43eb into PR head commit 2c7b806a2473402ae2a0b9f0e261c70fe18b13e1
[2021-04-21T12:03:46.827Z] Merge succeeded, producing 2c7b806a2473402ae2a0b9f0e261c70fe18b13e1
[2021-04-21T12:03:46.827Z] Checking out Revision 2c7b806a2473402ae2a0b9f0e261c70fe18b13e1 (PR-2054)
[2021-04-21T12:03:46.673Z]  > git config core.sparsecheckout # timeout=10
[2021-04-21T12:03:46.681Z]  > git checkout -f 2c7b806a2473402ae2a0b9f0e261c70fe18b13e1 # timeout=15
[2021-04-21T12:03:46.766Z]  > git remote # timeout=10
[2021-04-21T12:03:46.776Z]  > git config --get remote.origin.url # timeout=10
[2021-04-21T12:03:46.786Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-04-21T12:03:46.790Z]  > git merge b588a8854db46ed90a8f7e1189b52df5c40d43eb # timeout=10
[2021-04-21T12:03:46.816Z]  > git rev-parse HEAD^{commit} # timeout=10
[2021-04-21T12:03:46.830Z]  > git config core.sparsecheckout # timeout=10
[2021-04-21T12:03:46.835Z]  > git checkout -f 2c7b806a2473402ae2a0b9f0e261c70fe18b13e1 # timeout=15
[2021-04-21T12:03:50.513Z] Commit message: "feta(node): add suppport to node 16"
[2021-04-21T12:03:50.513Z] First time build. Skipping changelog.
[2021-04-21T12:03:50.513Z] Cleaning workspace
[2021-04-21T12:03:50.592Z]  > git --version # timeout=10
[2021-04-21T12:03:50.595Z]  > git --version # 'git version 2.17.1'
[2021-04-21T12:03:50.600Z] fatal: bad object 164198de35fb31a0fead9e8a4d426de6c61f8948
[2021-04-21T12:03:51.443Z] Masking supported pattern matches of $JOB_GCS_BUCKET or $NOTIFY_TO
[2021-04-21T12:03:50.516Z]  > git rev-parse --verify HEAD # timeout=10
[2021-04-21T12:03:50.522Z] Resetting working tree
[2021-04-21T12:03:50.522Z]  > git reset --hard # timeout=10
[2021-04-21T12:03:50.556Z]  > git clean -fdx # timeout=10
[2021-04-21T12:03:51.532Z] Timeout set to expire in 3 hr 0 min
[2021-04-21T12:03:51.569Z] The timestamps step is unnecessary when timestamps are enabled for all Pipeline builds.
[2021-04-21T12:03:51.877Z] [INFO] Number of builds to be searched 10
[2021-04-21T12:03:52.051Z] [INFO] 'shallow' is forced to be disabled when running on PullRequests
[2021-04-21T12:03:52.082Z] Running in /var/lib/jenkins/workspace/ejs_apm-agent-nodejs-mbp_PR-2054/src/github.com/elastic/apm-agent-nodejs
[2021-04-21T12:03:52.129Z] [INFO] gitCheckout: Checkout SCM PR-2054 with some customisation.
[2021-04-21T12:03:52.173Z] [INFO] Override default checkout
[2021-04-21T12:03:52.250Z] Sleeping for 10 sec
[2021-04-21T12:04:02.275Z] The recommended git tool is: git
[2021-04-21T12:04:02.410Z] using credential f6c7695a-671e-4f4f-a331-acdce44ff9ba
[2021-04-21T12:04:02.434Z] Cloning the remote Git repository
[2021-04-21T12:04:02.450Z] Cloning repository [email protected]:elastic/apm-agent-nodejs.git
[2021-04-21T12:04:02.477Z]  > git init /var/lib/jenkins/workspace/ejs_apm-agent-nodejs-mbp_PR-2054/src/github.com/elastic/apm-agent-nodejs # timeout=10
[2021-04-21T12:04:02.487Z] Using reference repository: /var/lib/jenkins/.git-references/apm-agent-nodejs.git
[2021-04-21T12:04:02.487Z] Fetching upstream changes from [email protected]:elastic/apm-agent-nodejs.git
[2021-04-21T12:04:02.487Z]  > git --version # timeout=10
[2021-04-21T12:04:02.497Z]  > git --version # 'git version 2.17.1'
[2021-04-21T12:04:02.498Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-04-21T12:04:02.502Z]  > git fetch --tags --progress -- [email protected]:elastic/apm-agent-nodejs.git +refs/heads/*:refs/remotes/origin/* # timeout=10
[2021-04-21T12:04:04.034Z]  > git config remote.origin.url [email protected]:elastic/apm-agent-nodejs.git # timeout=10
[2021-04-21T12:04:04.037Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
[2021-04-21T12:04:04.050Z]  > git config remote.origin.url [email protected]:elastic/apm-agent-nodejs.git # timeout=10
[2021-04-21T12:04:04.059Z] Fetching upstream changes from [email protected]:elastic/apm-agent-nodejs.git
[2021-04-21T12:04:04.060Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-04-21T12:04:04.064Z]  > git fetch --tags --progress -- [email protected]:elastic/apm-agent-nodejs.git +refs/pull/2054/head:refs/remotes/origin/PR-2054 +refs/heads/master:refs/remotes/origin/master # timeout=10
[2021-04-21T12:04:05.319Z] Checking out Revision 2c7b806a2473402ae2a0b9f0e261c70fe18b13e1 (origin/PR-2054)
[2021-04-21T12:04:05.381Z] Commit message: "feta(node): add suppport to node 16"
[2021-04-21T12:04:05.404Z]  > git --version # timeout=10
[2021-04-21T12:04:05.408Z]  > git --version # 'git version 2.17.1'
[2021-04-21T12:04:05.414Z] fatal: bad object 164198de35fb31a0fead9e8a4d426de6c61f8948
[2021-04-21T12:04:05.309Z]  > git rev-parse origin/PR-2054^{commit} # timeout=10
[2021-04-21T12:04:05.322Z]  > git config core.sparsecheckout # timeout=10
[2021-04-21T12:04:05.329Z]  > git checkout -f 2c7b806a2473402ae2a0b9f0e261c70fe18b13e1 # timeout=10
[2021-04-21T12:04:06.519Z] Masking supported pattern matches of $GIT_USERNAME or $GIT_PASSWORD
[2021-04-21T12:04:07.168Z] + git fetch https://****:****@github.com/elastic/apm-agent-nodejs.git +refs/pull/*/head:refs/remotes/origin/pr/*
[2021-04-21T12:04:07.828Z] Running in /var/lib/jenkins/workspace/ejs_apm-agent-nodejs-mbp_PR-2054/src/github.com/elastic/apm-agent-nodejs/.git
[2021-04-21T12:04:07.952Z] Archiving artifacts
[2021-04-21T12:04:08.733Z] + git rev-parse HEAD
[2021-04-21T12:04:09.099Z] + git rev-parse HEAD
[2021-04-21T12:04:09.428Z] + git rev-parse origin/pr/2054
[2021-04-21T12:04:09.495Z] [INFO] githubEnv: Found Git Build Cause: pr
[2021-04-21T12:04:09.859Z] Masking supported pattern matches of $GITHUB_TOKEN
[2021-04-21T12:04:10.875Z] [WARN] githubApiCall: The REST API call https://api.github.com/repos/elastic/apm-agent-nodejs/pulls/2054/reviews return 0 elements
[2021-04-21T12:04:10.953Z] [INFO] githubPrCheckApproved: Title: feta(node): add suppport to node 16 - User: sibelius - Author Association: CONTRIBUTOR
[2021-04-21T12:04:11.352Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet
[2021-04-21T12:04:11.352Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)
[2021-04-21T12:04:11.453Z] [INFO] Let's stop build #1. The PR is not allowed to run in the CI yet
[2021-04-21T12:04:11.487Z] Sleeping for 5 sec
[2021-04-21T12:04:12.846Z] Stage "Test" skipped due to earlier failure(s)
[2021-04-21T12:04:12.955Z] Stage "TAV Test" skipped due to earlier failure(s)
[2021-04-21T12:04:13.071Z] Stage "Edge Test" skipped due to earlier failure(s)
[2021-04-21T12:04:13.284Z] Stage "Nightly Test" skipped due to earlier failure(s)
[2021-04-21T12:04:13.302Z] Stage "Nightly Test - No async hooks" skipped due to earlier failure(s)
[2021-04-21T12:04:13.317Z] Stage "RC Test" skipped due to earlier failure(s)
[2021-04-21T12:04:13.333Z] Stage "RC Test - No async hooks" skipped due to earlier failure(s)
[2021-04-21T12:04:13.501Z] Failed in branch Nightly Test
[2021-04-21T12:04:13.514Z] Failed in branch Nightly Test - No async hooks
[2021-04-21T12:04:13.526Z] Failed in branch RC Test
[2021-04-21T12:04:13.537Z] Failed in branch RC Test - No async hooks
[2021-04-21T12:04:13.782Z] Stage "Integration Tests" skipped due to earlier failure(s)
[2021-04-21T12:04:13.887Z] Stage "Release" skipped due to earlier failure(s)
[2021-04-21T12:04:13.934Z] Stage "Release" skipped due to earlier failure(s)
[2021-04-21T12:04:14.086Z] Stage "Benchmarks" skipped due to earlier failure(s)
[2021-04-21T12:04:14.432Z] Running on Jenkins in /var/lib/jenkins/workspace/ejs_apm-agent-nodejs-mbp_PR-2054
[2021-04-21T12:04:14.591Z] [INFO] getVaultSecret: Getting secrets
[2021-04-21T12:04:14.892Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-04-21T12:04:15.943Z] + chmod 755 generate-build-data.sh
[2021-04-21T12:04:15.943Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/apm-agent-nodejs-mbp/PR-2054/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/apm-agent-nodejs-mbp/PR-2054/runs/1 ABORTED 174907
[2021-04-21T12:04:16.193Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/apm-agent-nodejs-mbp/PR-2054/runs/1/steps/?limit=10000 -o steps-info.json
[2021-04-21T12:04:16.744Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/apm-agent-nodejs-mbp/PR-2054/runs/1/tests/?status=FAILED -o tests-errors.json
[2021-04-21T12:04:16.744Z] Retry 1/3 exited 22, retrying in 1 seconds...
[2021-04-21T12:04:17.656Z] Retry 2/3 exited 22, retrying in 2 seconds...

@trentm
Copy link
Member

trentm commented Apr 21, 2021

@sibelius Thanks for the start! There is actually a start at this for node v15 here that shows a few more places to be updated: #1841

The owner of that PR ultimate closed it because I let final test work on that PR languish. I will start a separate PR to update those other places as well, and to continue to poke at those final test failures being discussed at #1841

@trentm
Copy link
Member

trentm commented Apr 21, 2021

My alternative PR is here: #2055

@trentm
Copy link
Member

trentm commented Apr 22, 2021

Closing in favour of #2055

@trentm trentm closed this Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add support to node 16
3 participants
@sibelius @apmmachine @trentm