Allow creating DMs/adding users by QR code #2276

TR-SLimey · 2020-10-20T15:17:39Z

Fixes #2025

Also fixes a small typo in RoomDirectoryItem.kt

As requested by @BillCarsonFr, I've made adding by QR code more seamless by automatically creating a room as soon as the QR code is scanned, or switching to a room if it already exists. Sadly, no auto-accept yet :(

Pull Request Checklist

Changes have been tested on an Android device or Android emulator with API 21
UI change has been tested on both light and dark themes
Pull request is based on the develop branch
Pull request updates CHANGES.md
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off

Screenshots

Sharing user by QR code (Light theme)

Sharing user by QR code (Dark theme)

Add by QR code (Light theme)

Add by QR code (Dark theme)

Signed-off-by: TR_SLimey | [email protected] | @tr_slimey:an-atom-in.space

Fixes #2252

At the moment, it's just a copy of item_verification_qr_code.xml but reusing it seemed like a bad idea

…into develop

Removed unused dependencies and some unnecessary newlines

bmarty · 2020-10-20T20:05:39Z

Thanks for the PR. First comment: please make sure that every strings displayed to the user are not hard-coded and are defined in the file strings.xml. I will add more comments later.

Be aware that we are reworking the screen where you have added the "Add by QR code". Maybe if the purpose is to create DM by scanning a QR code, a first dialog can be displayed when clicking on the create DM floating action button to ask if the user want to scan a QR code, or if he wants to search for the user manually. WDYT?

…time Feature/bca/perf better send time

…migration Fix crpyto store migration from RiotX.

Feature/bma/version code

#2276 (comment) #2276 (comment) #2276 (comment) #2276 (comment) #2276 (comment) #2276 (comment)

Seemed annoying while testing

#2276 (comment)

TR-SLimey · 2020-10-22T21:56:33Z

Should be better now hopefully :) If there's anything else I should change, let me know. Meanwhile, I'll be working on that FAB menu.

At the moment, it's just a copy of item_verification_qr_code.xml but reusing it seemed like a bad idea

Removed unused dependencies and some unnecessary newlines

#2276 (comment) #2276 (comment) #2276 (comment) #2276 (comment) #2276 (comment) #2276 (comment)

Seemed annoying while testing

#2276 (comment)

…into develop

bmarty · 2020-10-23T13:42:01Z

I'm seeing a lot of commits now, which are not related to this PR. What happened?

TR-SLimey · 2020-10-23T13:44:47Z

Argh. I was trying to pull the latest changes from the main repo into my fork and apparently I messed something up. I should have probably done this in a separate branch. I'll close this PR and re-do it.

Onuray Sahin and others added 13 commits October 16, 2020 15:18

Fix crpyto store migration from RiotX.

6531ba6

Fixes #2252

Initial work on adding by QR code

346ed1b

Scanning QR codes of known users will now move to DM

c87cd48

Minor cleanup

6ad0abb

Fixed minor unrelated typo

d4eccdc

Instantly create room on QR code scan

1b3c871

Improved MXID extraction from matrix.to URI

9cae432

Benoit code review fixes.

6d3a659

Merge branch 'develop' into feature/ons/fix_riotx_crypto_migration

151f361

Added an XML file for sharing QR codes

c4d7de0

At the moment, it's just a copy of item_verification_qr_code.xml but reusing it seemed like a bad idea

Merge branch 'develop' of https://github.com/TR-SLimey/element-android …

c1944e4

…into develop

Update CHANGES.md

5617c9d

Split up line over 160 chars long to pass code quality

c2a2a00

TR-SLimey changed the title ~~Add creating DMs/adding users by QR code~~ Allow creating DMs/adding users by QR code Oct 20, 2020

TR-SLimey added 3 commits October 20, 2020 18:24

Toasty :D

66da660

Increased size of sharing QR code (looks better)

65c4f2d

Added ability to share user profile as QR code

4eec056

TR-SLimey marked this pull request as ready for review October 20, 2020 18:08

TR-SLimey and others added 9 commits October 20, 2020 19:37

Minor cleanup to please CI

c115532

Removed unused dependencies and some unnecessary newlines

Add event sender in app thread

47746d6

add UI echo of reactions

41e168a

cleaning

ace412f

Stop thread on close session

6cca87d

fix sdk copyright

464ce16

Updated change log

89458a4

change log level

d319a35

Code review

dc8a6cc

bmarty added 2 commits October 20, 2020 22:12

Merge pull request #2235 from vector-im/feature/bca/perf_better_send_…

c88c2a1

…time Feature/bca/perf better send time

Merge pull request #2264 from vector-im/feature/ons/fix_riotx_crypto_…

f1e545a

…migration Fix crpyto store migration from RiotX.

bmarty and others added 5 commits October 22, 2020 22:03

Merge pull request #2284 from vector-im/feature/bma/versionCode

8392532

Feature/bma/version code

Rename item_share_qr_code.xml -> dialog_share_qr_code.xml

ee2ef2e

Fixes from review (part 1)

01fef81

#2276 (comment) #2276 (comment) #2276 (comment) #2276 (comment) #2276 (comment) #2276 (comment)

Removed toast when opening existing room

8a1aaeb

Seemed annoying while testing

Fixes from review (part 2)

6fe7cfb

#2276 (comment)

TR-SLimey added 19 commits October 23, 2020 11:08

Initial work on adding by QR code

f86bdb8

Scanning QR codes of known users will now move to DM

364ce8f

Minor cleanup

8997dcd

Fixed minor unrelated typo

4bc4487

Instantly create room on QR code scan

d988cfe

Improved MXID extraction from matrix.to URI

2eef51c

Added an XML file for sharing QR codes

bf7ddbd

At the moment, it's just a copy of item_verification_qr_code.xml but reusing it seemed like a bad idea

Update CHANGES.md

815b7f8

Split up line over 160 chars long to pass code quality

9a4f86f

Toasty :D

d54752c

Increased size of sharing QR code (looks better)

02c9aef

Added ability to share user profile as QR code

fab7a4a

Minor cleanup to please CI

1eede27

Removed unused dependencies and some unnecessary newlines

Moved strings to strings.xml

eb55e81

Rename item_share_qr_code.xml -> dialog_share_qr_code.xml

62f97bc

Fixes from review (part 1)

2b87f1a

#2276 (comment) #2276 (comment) #2276 (comment) #2276 (comment) #2276 (comment) #2276 (comment)

Removed toast when opening existing room

48646ae

Seemed annoying while testing

Fixes from review (part 2)

b3ebc70

#2276 (comment)

Merge branch 'develop' of https://github.com/TR-SLimey/element-android …

5909789

…into develop

TR-SLimey closed this Oct 23, 2020

TR-SLimey mentioned this pull request Oct 23, 2020

Add users by QR code #2289

Closed

6 tasks

TR-SLimey mentioned this pull request Nov 10, 2020

Need 1 (or 2) icons for #2289 #2351

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow creating DMs/adding users by QR code #2276

Allow creating DMs/adding users by QR code #2276

TR-SLimey commented Oct 20, 2020 •

edited

Loading

bmarty commented Oct 20, 2020 •

edited

Loading

TR-SLimey commented Oct 22, 2020

bmarty commented Oct 23, 2020

TR-SLimey commented Oct 23, 2020 •

edited

Loading

Allow creating DMs/adding users by QR code #2276

Allow creating DMs/adding users by QR code #2276

Conversation

TR-SLimey commented Oct 20, 2020 • edited Loading

Pull Request Checklist

bmarty commented Oct 20, 2020 • edited Loading

TR-SLimey commented Oct 22, 2020

bmarty commented Oct 23, 2020

TR-SLimey commented Oct 23, 2020 • edited Loading

TR-SLimey commented Oct 20, 2020 •

edited

Loading

bmarty commented Oct 20, 2020 •

edited

Loading

TR-SLimey commented Oct 23, 2020 •

edited

Loading