-
Notifications
You must be signed in to change notification settings - Fork 783
Add users by QR code #2289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add users by QR code #2289
Conversation
The CI was unimpressed by my previous cleanup
Merge branch 'develop' into 'TR-SLimey/develop'
Also added comment about PR #2342
If gjpower can, so can I :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thanks for the update.
The PR is really great! I have some few remark, and especially one about moving the treatment into the ViewModel. Feel free to ask if you need help, or if you prefer us to do the change.
QR code dialog and QR code scanning tested OK on my device.
Thanks again!
vector/src/main/java/im/vector/app/features/createdirect/CreateDirectRoomByQrCodeFragment.kt
Outdated
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/createdirect/CreateDirectRoomByQrCodeFragment.kt
Outdated
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/createdirect/CreateDirectRoomByQrCodeFragment.kt
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/createdirect/CreateDirectRoomByQrCodeFragment.kt
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/createdirect/CreateDirectRoomByQrCodeFragment.kt
Outdated
Show resolved
Hide resolved
Hey, @bmarty I noticed this PR is still sitting around, anything I can do to help it along or is it blocked by something? |
Hello @TR-SLimey , I took your commits and put them here #2417 |
Second attempt (#2276) including all fixes from review of last PR.
Fixes #2025
Also fixes a small typo in RoomDirectoryItem.kt
Pull Request Checklist
Screenshots
Sharing user by QR code (Light theme)Sharing user by QR code (Dark theme)
Tested and working:
Signed-off-by: TR_SLimey | [email protected] | @tr_slimey:an-atom-in.space