Skip to content

Add users by QR code #2289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 21 commits into from
Closed

Add users by QR code #2289

wants to merge 21 commits into from

Conversation

TR-SLimey
Copy link
Contributor

@TR-SLimey TR-SLimey commented Oct 23, 2020

Second attempt (#2276) including all fixes from review of last PR.

Fixes #2025

Also fixes a small typo in RoomDirectoryItem.kt

Pull Request Checklist

  • Changes have been tested on an Android device or Android emulator with API 21
  • UI change has been tested on both light and dark themes
  • Pull request is based on the develop branch
  • Pull request updates CHANGES.md
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
Screenshots Sharing user by QR code (Light theme)

image

Sharing user by QR code (Dark theme)

image

Tested and working:

  • Request permissions before opening scanner
  • Cleanly close scanner if permissions not granted
  • Open scanner if permissions granted (even after denied previously)
  • Open DM if it already exists
  • Create DM if it does not
  • Let user know that they cannot DM themselves if they try
  • Show progress while creating DM
  • Tell the user if QR code is not valid
  • Generate valid QR codes in user profile

Signed-off-by: TR_SLimey | [email protected] | @tr_slimey:an-atom-in.space

@TR-SLimey TR-SLimey marked this pull request as ready for review October 28, 2020 16:16
@TR-SLimey TR-SLimey changed the title [WIP] Add users by QR code Add users by QR code Oct 28, 2020
The CI was unimpressed by my previous cleanup
Merge branch 'develop' into 'TR-SLimey/develop'
Also added comment about PR #2342
If gjpower can, so can I :P
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thanks for the update.
The PR is really great! I have some few remark, and especially one about moving the treatment into the ViewModel. Feel free to ask if you need help, or if you prefer us to do the change.
QR code dialog and QR code scanning tested OK on my device.
Thanks again!

@TR-SLimey
Copy link
Contributor Author

Hey, @bmarty I noticed this PR is still sitting around, anything I can do to help it along or is it blocked by something?

@BillCarsonFr
Copy link
Member

BillCarsonFr commented Nov 18, 2020

Hello @TR-SLimey , I took your commits and put them here #2417
In a more generic PR to improve invite.
Closing this PR in favor of that one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QR-codes for faster contact sharing
3 participants