Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(wokwi): Add I2C Master test and enable GPIO and PSRAM tests #10848

Merged
merged 7 commits into from
Feb 19, 2025

Conversation

lucasssvaz
Copy link
Collaborator

Description of Change

Added new I2C master test.
Enabled already existing PSRAM and GPIO tests.

Tests scenarios

Locally

Copy link
Contributor

github-actions bot commented Jan 13, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello lucasssvaz, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 188e1e7

Copy link
Contributor

github-actions bot commented Jan 13, 2025

Test Results

 62 files   62 suites   6m 38s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
153 runs  153 ✅ 0 💤 0 ❌

Results for commit 188e1e7.

♻️ This comment has been updated with latest results.

@me-no-dev me-no-dev added the Status: Review needed Issue or PR is awaiting review label Feb 19, 2025
@SuGlider SuGlider self-requested a review February 19, 2025 17:00
Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Feb 19, 2025
@me-no-dev me-no-dev merged commit 978b441 into espressif:master Feb 19, 2025
28 checks passed
@tyeth
Copy link
Contributor

tyeth commented Feb 27, 2025

@lucasssvaz any chance this i2c test suite can be extended to also perform an i2c scan before initialising the i2c component, as we are seeing ESP_ERR_TIMEOUT: I2C Bus Busy returned from a scan (worked @ 3.0.7, broken in 3.1.1, unchanged code).

@lucasssvaz
Copy link
Collaborator Author

@lucasssvaz any chance this i2c test suite can be extended to also perform an i2c scan before initialising the i2c component, as we are seeing ESP_ERR_TIMEOUT: I2C Bus Busy returned from a scan (worked @ 3.0.7, broken in 3.1.1, unchanged code).

Sure, I will take a look. Is there anything specific you think would be nice to have in the test ?

@tyeth
Copy link
Contributor

tyeth commented Feb 28, 2025 via email

@lucasssvaz
Copy link
Collaborator Author

@tyeth PTAL at #11022. Added a test to scan the bus while the Wi-Fi is running.

@tyeth
Copy link
Contributor

tyeth commented Feb 28, 2025

Looks great! Thanks for going the extra mile 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: CI & Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants