-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(wokwi): Add I2C Master test and enable GPIO and PSRAM tests #10848
Conversation
👋 Hello lucasssvaz, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 62 files 62 suites 6m 38s ⏱️ Results for commit 188e1e7. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@lucasssvaz any chance this i2c test suite can be extended to also perform an i2c scan before initialising the i2c component, as we are seeing |
Sure, I will take a look. Is there anything specific you think would be nice to have in the test ? |
Not really, although it now turns out that we see a normal successful scan
with the plain Wire Scan example, but when using the same code in our
WipperSnapper firmware (with wifi active) we are seeing the
ESP_ERR_TIMEOUT: I2C Bus Busy messages at random addresses when scanning.
Maybe doing the scan with other peripherals / tasks active would be a good
thing to test?
We are only experiencing this on the ESP32-S2 based boards in BSP 3.1.x for
whatever that is worth.
…On Fri, 28 Feb 2025 at 03:19, Lucas Saavedra Vaz ***@***.***> wrote:
@lucasssvaz <https://github.com/lucasssvaz> any chance this i2c test
suite can be extended to also perform an i2c scan before initialising the
i2c component, as we are seeing ESP_ERR_TIMEOUT: I2C Bus Busy returned
from a scan (worked @ 3.0.7, broken in 3.1.1, unchanged code).
Sure, I will take a look. Is there anything specific you think would be
nice to have in the test ?
—
Reply to this email directly, view it on GitHub
<#10848 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTBZ47BULM32SAJ6SFSURL2R7IUDAVCNFSM6AAAAABVBVM2FSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBZGYZDGNRYGM>
.
You are receiving this because you commented.Message ID:
***@***.***>
[image: lucasssvaz]*lucasssvaz* left a comment
(espressif/arduino-esp32#10848)
<#10848 (comment)>
@lucasssvaz <https://github.com/lucasssvaz> any chance this i2c test
suite can be extended to also perform an i2c scan before initialising the
i2c component, as we are seeing ESP_ERR_TIMEOUT: I2C Bus Busy returned
from a scan (worked @ 3.0.7, broken in 3.1.1, unchanged code).
Sure, I will take a look. Is there anything specific you think would be
nice to have in the test ?
—
Reply to this email directly, view it on GitHub
<#10848 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTBZ47BULM32SAJ6SFSURL2R7IUDAVCNFSM6AAAAABVBVM2FSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBZGYZDGNRYGM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Looks great! Thanks for going the extra mile 🙏 |
Description of Change
Added new I2C master test.
Enabled already existing PSRAM and GPIO tests.
Tests scenarios
Locally