Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(i2c): Add test to scan bus #11022

Merged
merged 3 commits into from
Mar 5, 2025
Merged

test(i2c): Add test to scan bus #11022

merged 3 commits into from
Mar 5, 2025

Conversation

lucasssvaz
Copy link
Collaborator

Description of Change

Add scan test to i2c_master.

Tests scenarios

Local and CI

Related links

#10848

@lucasssvaz lucasssvaz self-assigned this Feb 28, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 28, 2025 •
edited
Loading

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello lucasssvaz, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 62cf432

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 28, 2025 •
edited
Loading

Test Results

 76 files   76 suites   12m 39s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit 62cf432.

♻️ This comment has been updated with latest results.

@lucasssvaz lucasssvaz added the Status: Review needed Issue or PR is awaiting review label Feb 28, 2025
@lucasssvaz lucasssvaz mentioned this pull request Feb 28, 2025
Merged
@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Mar 5, 2025
@me-no-dev me-no-dev merged commit 9e2f755 into espressif:master Mar 5, 2025
43 checks passed
@lucasssvaz lucasssvaz deleted the test/i2c_scan branch March 19, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyeth tyeth tyeth approved these changes

@me-no-dev me-no-dev me-no-dev approved these changes

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees

@lucasssvaz lucasssvaz

Labels
Status: Pending Merge Pull Request is ready to be merged Type: CI & Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucasssvaz @tyeth @me-no-dev @P-R-O-C-H-Y