Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zigbee): use correct pressure cluster function in setTolerance #11008

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

oddlama
Copy link
Contributor

@oddlama oddlama commented Feb 25, 2025

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. Please check Contributing guide
  5. Please confirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

This entire section above can be deleted if all items are checked.


Description of Change

Fixed calling a temperature cluster function on a pressure cluster in setTolerance.

Tests scenarios

ESP32-C6

Related links

N/A

@CLAassistant
Copy link

CLAassistant commented Feb 25, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Feb 25, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello oddlama, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 264d111

Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch :) Thanks @oddlama for the fix

@P-R-O-C-H-Y P-R-O-C-H-Y added Area: Zigbee Issues and Feature Request about Zigbee Status: Pending Merge Pull Request is ready to be merged labels Feb 25, 2025
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C6💚 -960💚 -0.020.00000.000.00
ESP32H2💚 -960💚 -0.020.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C6ESP32H2
ExampleFLASHRAMFLASHRAM
Zigbee/examples/Zigbee_Analog_Input_Output0000
Zigbee/examples/Zigbee_CarbonDioxide_Sensor0000
Zigbee/examples/Zigbee_Color_Dimmable_Light0000
Zigbee/examples/Zigbee_Color_Dimmer_Switch0000
Zigbee/examples/Zigbee_Contact_Switch0000
Zigbee/examples/Zigbee_Dimmable_Light0000
Zigbee/examples/Zigbee_OTA_Client0000
Zigbee/examples/Zigbee_Occupancy_Sensor0000
Zigbee/examples/Zigbee_On_Off_Light0000
Zigbee/examples/Zigbee_On_Off_Switch0000
Zigbee/examples/Zigbee_Pressure_Flow_Sensor💚 -960💚 -960
Zigbee/examples/Zigbee_Range_Extender0000
Zigbee/examples/Zigbee_Scan_Networks0000
Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy0000
Zigbee/examples/Zigbee_Temperature_Sensor0000
Zigbee/examples/Zigbee_Thermostat0000
Zigbee/examples/Zigbee_Vibration_Sensor0000
Zigbee/examples/Zigbee_Window_Covering0000

@me-no-dev me-no-dev merged commit 1467d87 into espressif:master Feb 25, 2025
47 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Zigbee Issues and Feature Request about Zigbee Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants