Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove / update old notes & remove some old skipped tests #3605

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Feb 4, 2025

What was wrong?

  • Remove note about ENSIP-15 breaking changes from v6
  • Remove old, un-tested uncles tests as they are no longer a thing after switch to PoS.
  • Change TODO note on breaking changes from v7 -> v8

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

courtesy of gpt o3-mini-high 🤔

       .-=========-.
       |  IRISH    |
       |  DOODLE   |
       '-----------'
            ||
         .-'''''-.
       .'  .-. .-.  '.
      /   ( o ) ( o )  \
     |     '-'   '-'    |
     |  \             / |
      \  '.         .'  /
       '.  `'-----'`  .'
         '-._______.-'
           |     |
         __|     |__
        /  |     |  \
       /   |     |   \
      /____|_____|____\
         (_________)

@fselmo fselmo marked this pull request as ready for review February 4, 2025 22:18
@fselmo fselmo changed the title Rm ensip15 note Remove /update old notes & remove some old skipped tests Feb 4, 2025
@fselmo fselmo changed the title Remove /update old notes & remove some old skipped tests Remove / update old notes & remove some old skipped tests Feb 4, 2025
@fselmo
Copy link
Collaborator Author

fselmo commented Feb 4, 2025

Chore PR to remove some old things. Follow-up q, should we deprecate eth_getUncle* endpoints / methods to be removed in v8? Could add that in here as well while eyes are there.

@fselmo fselmo requested review from kclowes, pacrob and reedsa February 4, 2025 22:37
@pacrob
Copy link
Contributor

pacrob commented Feb 5, 2025

Chore PR to remove some old things. Follow-up q, should we deprecate eth_getUncle* endpoints / methods to be removed in v8? Could add that in here as well while eyes are there.

makes sense to me

@pacrob pacrob removed their request for review March 25, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants