Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove / update old notes & remove some old skipped tests #3605

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+2 −20
Open

Remove / update old notes & remove some old skipped tests #3605

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
818802d
Remove old ENSIP-15 breaking changes note from docs
fselmo Feb 4, 2025
e7ca504
Remove uncle tests as irrelevant after PoW->PoS
fselmo Feb 4, 2025
c8b65d2
Update TODO note as v7->v8 breaking changes
fselmo Feb 4, 2025
9023e45
newsfragment for #3605
fselmo Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions docs/ens_overview.rst
View file
Original file line number Diff line number Diff line change
@@ -11,17 +11,6 @@ The :mod:`ens` module is included with web3.py. It provides an interface to look
domains and addresses, add resolver records, or get and set metadata.


.. note::

web3.py ``v6.6.0`` introduced ENS name normalization standard
`ENSIP-15 <https://docs.ens.domains/ensip/15>`_.
This update to ENS name validation and normalization won't affect ~99%
of names but may prevent invalid names from being created and from interacting with
the ENS contracts via web3.py. We feel strongly that this change, though breaking,
is in the best interest of our users as it ensures compatibility with the latest ENS
standards.


Setup
-----

1 change: 1 addition & 0 deletions newsfragments/3605.internal.rst
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Update some outdated TODO notes in code & remove old un-tested uncles tests as no longer relevant post-merge.
8 changes: 0 additions & 8 deletions web3/_utils/module_testing/eth_module.py
View file
Original file line number Diff line number Diff line change
@@ -4520,14 +4520,6 @@ def test_eth_wait_for_transaction_receipt_with_log_entry(
assert log_entry["transactionIndex"] == 0
assert log_entry["transactionHash"] == HexBytes(txn_hash_with_log)

def test_eth_getUncleByBlockHashAndIndex(self, w3: "Web3") -> None:
# TODO: how do we make uncles....
pass

def test_eth_getUncleByBlockNumberAndIndex(self, w3: "Web3") -> None:
# TODO: how do we make uncles....
pass

def test_eth_new_filter(self, w3: "Web3") -> None:
filter = w3.eth.filter({})

2 changes: 1 addition & 1 deletion web3/_utils/normalizers.py
View file
Original file line number Diff line number Diff line change
@@ -228,7 +228,7 @@ def abi_ens_resolver(
return type_str, validate_name_has_address(_ens, val)
except NameNotFound as e:
# TODO: This try/except is to keep backwards compatibility when we
# removed the mainnet requirement. Remove this in web3.py v7 and allow
# removed the mainnet requirement. Remove this in web3.py v8 and allow
# NameNotFound to raise.
if not isinstance(_ens, StaticENS):
raise InvalidAddress(f"{e}")