Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code parameter has opposite effect #912

Closed
nmalcolm opened this issue Jul 30, 2013 · 1 comment
Closed

Code parameter has opposite effect #912

nmalcolm opened this issue Jul 30, 2013 · 1 comment
Assignees
@scannell

Comments

@nmalcolm
Copy link

https://github.com/facebook/hiphop-php/blob/master/hphp/doc/server.stats

code: (optional) only output stats of pages that have response code

My experience shows that adding the code parameter in fact does the opposite and excludes the response code in the result. Either there's something wrong with the implementation or the docs are outdated here.
@scannell
Copy link
Contributor

Looking at the code you are correct, this is just a bug. I should have a fix for this soon.

@ghost ghost assigned scannell Jul 30, 2013
facebook-github-bot pushed a commit that referenced this issue Oct 16, 2024
@facebook-github-bot
update itertools 0.12.1 -> 0.13.0
58fee27 
Summary:
# Motivation

And if there is one is one design mistake Rust ecosystem made, it is making [`group_by` weird](rust-itertools/itertools#374) and possible for users to, quote:

> I spent several hours debugging my code written using the group_by function.

Luckily for internal users, the build tooling responds accordingly and fails build for all usages of deprecated API. Thus, there is a need to adjust all of them manually.

# [Release notes](https://github.com/rust-itertools/itertools/blob/master/CHANGELOG.md#0130)

### Breaking
- Removed implementation of `DoubleEndedIterator` for `ConsTuples` (#853)
- Made `MultiProduct` fused and fixed on an empty iterator (#835, #834)
- Changed `iproduct!` to return tuples for maxi one iterator too (#870)
- Changed `PutBack::put_back` to return the old value (#880)
- Removed deprecated `repeat_call, Itertools::{foreach, step, map_results, fold_results}` (#878)
- Removed `TakeWhileInclusive::new` (#912)

NOTE: Quick search didn't tell me anything related to breaking changes above, CI will tell. And, of course, scream to me if it breaks your personal build.

Reviewed By: anps77

Differential Revision: D64306014

fbshipit-source-id: 881ac716e1dc23968d4a28000fdaccdbf9097ec2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scannell scannell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nmalcolm @scannell