1: add freebsd support on current_executable_path(). #878
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2: fix build on macosx. 3: remove hardcode /proc/self/exe.
ghost
assigned Conflicts: hphp/util/current_executable.cpp
Closed
|
Hi Sara: Maybe you should apply the 3rd part of patch, remove hard code '/proc/self/exe' from embedded_data.cpp. without this patch, it sill not work with embedded data. thanks. |
|
@vanillahsu, I missed that, sorry. I'll fix it soon. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
Summary: # Motivation And if there is one is one design mistake Rust ecosystem made, it is making [`group_by` weird](rust-itertools/itertools#374) and possible for users to, quote: > I spent several hours debugging my code written using the group_by function. Luckily for internal users, the build tooling responds accordingly and fails build for all usages of deprecated API. Thus, there is a need to adjust all of them manually. # [Release notes](https://github.com/rust-itertools/itertools/blob/master/CHANGELOG.md#0130) ### Breaking - Removed implementation of `DoubleEndedIterator` for `ConsTuples` (#853) - Made `MultiProduct` fused and fixed on an empty iterator (#835, #834) - Changed `iproduct!` to return tuples for maxi one iterator too (#870) - Changed `PutBack::put_back` to return the old value (#880) - Removed deprecated `repeat_call, Itertools::{foreach, step, map_results, fold_results}` (#878) - Removed `TakeWhileInclusive::new` (#912) NOTE: Quick search didn't tell me anything related to breaking changes above, CI will tell. And, of course, scream to me if it breaks your personal build. Reviewed By: anps77 Differential Revision: D64306014 fbshipit-source-id: 881ac716e1dc23968d4a28000fdaccdbf9097ec2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2: fix build on macosx.
3: remove hardcode /proc/self/exe.