Fixed bundling ReactDOM #2
Conversation
| @@ -1,31 +1,29 @@ | |||
| { | |||
| "name": "react-final-form-html5-validation", | |||
| "version": "1.0.0", | |||
| "description": | |||
| "A swap-in replacement for 🏁 React Final Form's <Field> component to provide HTML5 Validation", | |||
| "description": "A swap-in replacement for 🏁 React Final Form's <Field> component to provide HTML5 Validation", | |||
There was a problem hiding this comment.
I think my npm formats package.json when doing a fresh install for some reason, no idea how to stop it (havent searched for it though 😉 ). Hope it's ok
| @@ -71,13 +69,19 @@ | |||
| "final-form": ">=4.0.0", | |||
| "prop-types": "^15.6.0", | |||
| "react": "^15.3.0 || ^16.0.0-0", | |||
| "react-dom": "^15.3.0 || ^16.0.0-0", | |||
There was a problem hiding this comment.
this was added! this peer dep was already required, only not in package.json
| plugins: [ | ||
| resolve({ jsnext: true, main: true }), | ||
| flow(), | ||
| commonjs({ include: 'node_modules/**' }), | ||
| umd && commonjs({ include: 'node_modules/**' }), |
There was a problem hiding this comment.
just extra guard, for non-umd build u dont want to use this plugin at all
package.json
Outdated
| @@ -69,7 +69,6 @@ | |||
| "final-form": ">=4.0.0", | |||
| "prop-types": "^15.6.0", | |||
| "react": "^15.3.0 || ^16.0.0-0", | |||
| "react-dom": "^15.3.0 || ^16.0.0-0", | |||
There was a problem hiding this comment.
this should be kept
There was a problem hiding this comment.
CI is failing now because this got removed
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 37 37
Branches 16 16
=====================================
Hits 37 37Continue to review full report at Codecov.
|
|
Any proof that this reduces bundle size? My initial test was pretty equivalent to |
|
I've made tests after running master 670401 Rollup build times also went down quite a bit (1.8s vs 422ms) |
|
The problem was using |
|
Um, confirmed. From 30 kb down to 1.45kb. 🤦♂️💥 |
|
Published in
|
No description provided.