Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use babel loose mode #3

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Use babel loose mode #3

merged 1 commit into from
Jul 18, 2018

Conversation

Andarist
Copy link
Contributor

@Andarist Andarist commented Jul 17, 2018

This reduces bundle size a little bit (thanks to loose mode) and keeps babel configs in sync between babelrc and rollup.config.js

es bundle size went down from 2097 to 1903 (gzipped, not minified)
umd.min bundle size went down from 1525 to 1405 (gzipped, minified)

Those numbers assumes ofc that #2 is merged in.

@codecov
Copy link

codecov bot commented Jul 17, 2018

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #3   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          37     37           
  Branches       16     16           
=====================================
  Hits           37     37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f21321...4eadb3c. Read the comment docs.

@erikras erikras merged commit cab743a into final-form:master Jul 18, 2018
@Andarist Andarist deleted the loose branch July 18, 2018 15:02
@erikras
Copy link
Member

erikras commented Jul 18, 2018

Published in v1.0.1.

dist/react-final-form-html5-validation.es.js went from 730K to 5.4K. 😱

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants