Skip to content

Unlock weblate translations #3873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 17, 2025
Merged

Conversation

volovikariel
Copy link
Contributor

@volovikariel volovikariel commented Mar 16, 2025

Unblocks open PRs related to Weblate:
#3078
#3082
#3609 (this one will require a comment, telling them to use Weblate, or alternatively, we could simply do it for them)
#3865


Weblate is blocked because of a merging issue in the spanish translation file.
This is the history of the changes on weblate: https://hosted.weblate.org/translate/flameshot/flameshot/es/?checksum=4f89fd8eec847a31#history


Simply rebasing after accepting the change from the Weblate branch seems to resolve the issue.
image

I have performed the rebase as instructed here: https://docs.weblate.org/en/latest/faq.html#how-to-fix-merge-conflicts-in-translations

NOTE: The polish changes are a side-effect of merging with Weblate

Eryk Michalak and others added 4 commits March 16, 2025 15:56
Currently translated at 100.0% (416 of 416 strings)

Translation: Flameshot/Flameshot
Translate-URL: https://hosted.weblate.org/projects/flameshot/flameshot/pl/
Currently translated at 100.0% (416 of 416 strings)

Translation: Flameshot/Flameshot
Translate-URL: https://hosted.weblate.org/projects/flameshot/flameshot/pl/
Currently translated at 100.0% (416 of 416 strings)

Translation: Flameshot/Flameshot
Translate-URL: https://hosted.weblate.org/projects/flameshot/flameshot/es/
Currently translated at 100.0% (416 of 416 strings)

Translation: Flameshot/Flameshot
Translate-URL: https://hosted.weblate.org/projects/flameshot/flameshot/es/
@volovikariel
Copy link
Contributor Author

volovikariel commented Mar 16, 2025

If I try to re-merge and re-rebase with Weblate locally after this PR's changes, I still get the same merging issue.
I think that's because I'm making the changes on my Fork, as opposed to on this repo.
I can't test it without setting up an entire Weblate repo for myself though...

If the issue is still not fixed after merging this PR, we'll have to look into why the issue still exists 👍

@mmahmoudian
Copy link
Member

@volovikariel thanks for the efforts. I will merge it now

@mmahmoudian mmahmoudian merged commit 042d690 into flameshot-org:master Mar 17, 2025
49 checks passed
@volovikariel
Copy link
Contributor Author

volovikariel commented Mar 17, 2025

@mmahmoudian you may have to run the wlc commands on your end, as I don't have access the weblate api credentials.

Perhaps a simple wlc pull ; wlc unlock will suffice? 🤔
More info on these commands here: https://docs.weblate.org/en/latest/wlc.html#commands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants