Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search for c++ packages does not work correctly #217

Closed
jme52 opened this issue Mar 3, 2021 · 5 comments
Closed

Search for c++ packages does not work correctly #217

jme52 opened this issue Mar 3, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@jme52
Copy link
Contributor

jme52 commented Mar 3, 2021

One of the "Featured topics" on https://fortran-lang.org/packages/ is c++. However, the search page https://fortran-lang.org/packages/search/?query=c++ seems to list many packages that don't have c++ in their list of tags or descriptions. Is it possible that the search inputs are not properly escaped?
@awvwgk awvwgk added the bug Something isn't working label Mar 3, 2021
@henilp105
Copy link
Member

The Featured topics has changed it to cpp as that '+' in c++ was being termed as a space replacer and to join a line of words
by the script thus only rendering the results for "c " that is c with 2 spaces. that has been fixed by replacing c++ by cpp.
request to close this issue as it has been resolved.

Thanks and Regards,
Henil Panchal

@henilp105
Copy link
Member

@awvwgk @jme52 This issue has been resolved thus request to close this issue #217.

Thanks and Regards,
Henil Panchal

@awvwgk
Copy link
Member

awvwgk commented Jan 18, 2022

I think this issue is still present, since we do not properly escape a search like c++ at the moment.

@henilp105
Copy link
Member

sir I can make the search code so should i contribute it.
Thanks and Regards,
Henil Panchal

@awvwgk
Copy link
Member

awvwgk commented Jan 18, 2022 •
edited
Loading

The package search is implemented here: https://github.com/fortran-lang/fortran-lang.org/blob/master/assets/js/package_search.js

Patches are welcome.

henilp105 added a commit to henilp105/fortran-lang.org that referenced this issue Jan 18, 2022
@henilp105
Resolves Issue fortran-lang#217
1d11969 
I have made a function that does the Regex and Resolves the issue for c++.

Thanks and Regards,
Henil Panchal
henilp105 added a commit to henilp105/fortran-lang.org that referenced this issue Jan 18, 2022
@henilp105
Merge pull request #4 from henilp105/henilp105-#217
cb0b7fb 
Resolves Issue fortran-lang#217
henilp105 added a commit to henilp105/fortran-lang.org that referenced this issue Jan 18, 2022
@henilp105
Resolves issue fortran-lang#217
b68ab45
henilp105 added a commit to henilp105/fortran-lang.org that referenced this issue Jan 18, 2022
@henilp105
Merge pull request #6 from henilp105/henilp105-patch#217
b4fbc4e 
Resolves Issue fortran-lang#217
henilp105 added a commit to henilp105/fortran-lang.org that referenced this issue Jan 18, 2022
@henilp105
Resolves Issue fortran-lang#217
a325937 
I have made a function that would handle all the search utilities and regex and this also solves the Issue fortran-lang#217.

Thanks and Regards,
Henil Panchal
@henilp105 henilp105 mentioned this issue Jan 18, 2022
Merged
henilp105 added a commit to henilp105/fortran-lang.org that referenced this issue Jan 18, 2022
@henilp105
Merge pull request #7 from henilp105/henilp105-search-patch#217
c435ab7 
Resolves Issue fortran-lang#217
@henilp105 henilp105 mentioned this issue Jan 18, 2022
Closed
henilp105 added a commit to henilp105/fortran-lang.org that referenced this issue Jan 19, 2022
@henilp105
Resolves Issue fortran-lang#217
8f615e5 
I have made a function that would handle all the search utilities and regex and this also solves the Issue fortran-lang#217.

Thanks and Regards,
Henil Panchal
henilp105 added a commit to henilp105/fortran-lang.org that referenced this issue Jan 19, 2022
@henilp105
Resolves Issue fortran-lang#217
5accd21 
I have done the changes that would handle all regex and this also solves the Issue fortran-lang#217.

Thanks and Regards,
Henil Panchal
@henilp105 henilp105 mentioned this issue Jan 19, 2022
Merged
henilp105 added a commit to henilp105/fortran-lang.org that referenced this issue Jan 19, 2022
@henilp105
Merge pull request #8 from henilp105/henilp105-issue#217-search-1
8cad573 
Resolves Issue fortran-lang#217
@henilp105 henilp105 mentioned this issue Jan 19, 2022
Closed
henilp105 added a commit to henilp105/fortran-lang.org that referenced this issue Jan 19, 2022
@henilp105
Resolves Issue fortran-lang#217
29d8651 
I have made the changes  that would handle all regex and this also solves the Issue fortran-lang#217.

Thanks and Regards,
Henil Panchal
@henilp105 henilp105 mentioned this issue Jan 19, 2022
Closed
henilp105 added a commit to henilp105/fortran-lang.org that referenced this issue Jan 19, 2022
@henilp105
Resolves Issue fortran-lang#217
46cf0d9 
I have made changes that would handle all package search regex and this also solves the Issue fortran-lang#217.

Thanks and Regards,
Henil Panchal
@henilp105 henilp105 mentioned this issue Jan 19, 2022
Merged
LKedward added a commit that referenced this issue Apr 16, 2022
@LKedward
Merge pull request #369 from henilp105/master
e4b5705 
Resolves Issue #217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@LKedward @awvwgk @jme52 @henilp105