Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves Issue #217 #369

Merged
merged 28 commits into from
Apr 16, 2022
Merged

Resolves Issue #217 #369

merged 28 commits into from
Apr 16, 2022

Conversation

henilp105
Copy link
Member

I have made changes that would handle all search package regex and this also solves the Issue #217.

Thanks and Regards,
Henil Panchal

henilp105 and others added 20 commits January 17, 2022 10:30
Missing "e" in "WG5: International Fortran Standards Committe" to Missing "e" in "WG5: International Fortran Standards committee"
it might seem a little odd for a spelling mistake but i wanted to contribute.

thanks and regards,
Henil Panchal
Co-authored-by: Sebastian Ehlert <[email protected]>
I have made a function that does the Regex and Resolves the issue for c++.

Thanks and Regards,
Henil Panchal
I have made a function that would handle all the search utilities and regex and this also solves the Issue fortran-lang#217.

Thanks and Regards,
Henil Panchal
I have made a function that would handle all the search utilities and regex and this also solves the Issue fortran-lang#217.

Thanks and Regards,
Henil Panchal
I have made the changes  that would handle all regex and this also solves the Issue fortran-lang#217.

Thanks and Regards,
Henil Panchal
I have made changes that would handle all package search regex and this also solves the Issue fortran-lang#217.

Thanks and Regards,
Henil Panchal
@henilp105
Copy link
Member Author

#build_preview

@github-actions
Copy link

This PR has been built with Jekyll and can be previewed at: https://fortran-lang.org/pr/369/

@henilp105
Copy link
Member Author

this works perfectly and also resolves all problems in the #217 thus I request the collaborators to merge the pull request.

Thanks and Regards,
Henil Panchal

@henilp105

This comment has been minimized.

@henilp105

This comment has been minimized.

@henilp105

This comment has been minimized.

@awvwgk
Copy link
Member

awvwgk commented Jan 25, 2022

@henilp105 Thanks for sharing. Be assured we haven't overlooked or forgotten your contribution. We will have a look as soon as time permits.

@awvwgk awvwgk requested a review from LKedward February 20, 2022 18:56
Copy link
Member

@LKedward LKedward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for looking into this @henilp105 - this is a clever solution, unfortunately I think we should fix this at the input stage by properly escaping characters in the input string with something like encodeURIComponent. This will be more robust, since it uses the GET parameters correctly, and will be more understandable/maintainable by future contributors.

Copy link
Member Author

@henilp105 henilp105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LKedward I have done the required changes, Please look into and merge the same , there had been no error on front end side ( thus not requiring the encodeURI ) , error in the code was due to the fortranLang.findGetParameter('query') function, opened a new issue for it #388

@henilp105
Copy link
Member Author

#build_preview

@github-actions
Copy link

This PR has been built with Jekyll and can be previewed at: https://fortran-lang.org/pr/369/

@henilp105
Copy link
Member Author

@awvwgk @LKedward This code works perfectly and also resolves the issue #217. all the requested changes have been implemented.

Thanks and Regards,
Henil Panchal

Copy link
Member

@LKedward LKedward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks Henil @henilp105, this all looks good to me! 👍 I've just left a few minor comments to cleanup.

@henilp105
Copy link
Member Author

@awvwgk @LKedward all the requested changes have been implemented. 👍

Thanks and Regards,
Henil Panchal

@LKedward
Copy link
Member

#build_preview

@github-actions
Copy link

This PR has been built with Jekyll and can be previewed at: https://fortran-lang.org/pr/369/

@LKedward
Copy link
Member

Great stuff, many thanks Henil!

@LKedward LKedward merged commit e4b5705 into fortran-lang:master Apr 16, 2022
@LKedward
Copy link
Member

#delete_preview

@github-actions
Copy link

The preview build for this PR has now been deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants