-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Probability Distribution and Statistical Functions -- Exponential Distribution Module #276
Probability Distribution and Statistical Functions -- Exponential Distribution Module #276
Conversation
@jvdp1 Accidental delete, please help. |
@Jim-215-Fisher For some reasons you also deleted the branch |
You can always recover the branch, however we might not be able to reopen this PR. Unless you haven't done so yet use the following the commands to recover the latest state of this branch:
|
I checked @Jim-215-Fisher repo and it seems that there is a branch called Therefore, I suggest to follow @awvwgk procedure. However, I would give it anoter name (e.g., |
This branch has been updated. All the corrections have been made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general LGTM. Only a few minor comments. Thank you for this work.
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
|
||
### Return value | ||
|
||
The result is a scalar or rank one array with a size of `array_size`, and as the same type of `lambda`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest to finish with "and has the same type as lambda
."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I noticed a few very minor details in the documentation, and continue to approve merging this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR @Jim-215-Fisher . Currently I have no additional comments.
@jvdp1 @epagone @Jim-215-Fisher Does anyone object if we merge this now? |
Good for me! |
No objections from me as well! Edit: just realised that has been merged already 👍 Thanks @Jim-215-Fisher and all reviewers! |
This is the second round of probability distribution and statistical functions, continuing from #240. Since the whole modular structure has been changed, each distribution will have its own PR.
This PR contains exponential distributions. Files uploaded are:
src/stdlib_stats_distribtuion_exponential.fypp
src/CMakeLists.txt
src/Makefile.manual
src/tests/test_distribution_exponential.f90
src/tests/CMakeLists.txt
src/tests/Makefile.manual
doc/specs/stdlib_stats_distribution_exponential.md
doc/specs/index.md