Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probability Distribution and Statistical Functions -- Exponential Distribution Module #276

Merged

Conversation

Jim-215-Fisher
Copy link
Contributor

This is the second round of probability distribution and statistical functions, continuing from #240. Since the whole modular structure has been changed, each distribution will have its own PR.
This PR contains exponential distributions. Files uploaded are:
src/stdlib_stats_distribtuion_exponential.fypp
src/CMakeLists.txt
src/Makefile.manual
src/tests/test_distribution_exponential.f90
src/tests/CMakeLists.txt
src/tests/Makefile.manual
doc/specs/stdlib_stats_distribution_exponential.md
doc/specs/index.md

@Jim-215-Fisher Jim-215-Fisher deleted the Distribution-Exponential branch December 22, 2021 16:06
@Jim-215-Fisher
Copy link
Contributor Author

Jim-215-Fisher commented Dec 22, 2021

@jvdp1 Accidental delete, please help.

@jvdp1
Copy link
Member

jvdp1 commented Dec 22, 2021

@Jim-215-Fisher For some reasons you also deleted the branch Distribution-Exponential, and so, we cannot reopen this PR.
However, the branch seems to still exist in your repo. So, I suggest to reopen a new PR for this module.

@awvwgk
Copy link
Member

awvwgk commented Dec 22, 2021

You can always recover the branch, however we might not be able to reopen this PR. Unless you haven't done so yet use the following the commands to recover the latest state of this branch:

git fetch [email protected]:fortran-lang/stdlib ff0da265f5fcf285ce04e15a09625edaefecf51c
git checkout FETCH_HEAD
git switch -c Distribution-Exponential
git push [email protected]:Jim-215-Fisher/stdlib Distribution-Exponential

@jvdp1
Copy link
Member

jvdp1 commented Dec 22, 2021

I checked @Jim-215-Fisher repo and it seems that there is a branch called Distribution-eponential, with this last commit: 212bc33dd7b1f43a59a8d904c6a17a1e4aae3eab called "convert expon name to exp and some words change" which does not seem to have been psuhed in this PR.

Therefore, I suggest to follow @awvwgk procedure. However, I would give it anoter name (e.g., Distribution-Expornential-1) and then to merge both branches if they diverge, to be sure you don't loose something.

@Jim-215-Fisher Jim-215-Fisher restored the Distribution-Exponential branch December 22, 2021 17:36
@Jim-215-Fisher
Copy link
Contributor Author

This branch has been updated. All the corrections have been made.

Copy link
Contributor

@gareth-nx gareth-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM. Only a few minor comments. Thank you for this work.


### Return value

The result is a scalar or rank one array with a size of `array_size`, and as the same type of `lambda`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to finish with "and has the same type as lambda."

Copy link
Contributor

@gareth-nx gareth-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I noticed a few very minor details in the documentation, and continue to approve merging this.

Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR @Jim-215-Fisher . Currently I have no additional comments.

@gareth-nx
Copy link
Contributor

@jvdp1 @epagone @Jim-215-Fisher Does anyone object if we merge this now?

@jvdp1
Copy link
Member

jvdp1 commented Jan 2, 2022

@jvdp1 @epagone @Jim-215-Fisher Does anyone object if we merge this now?

Good for me!

@gareth-nx gareth-nx merged commit 15f3270 into fortran-lang:master Jan 2, 2022
@epagone
Copy link

epagone commented Jan 2, 2022

No objections from me as well!

Edit: just realised that has been merged already 👍 Thanks @Jim-215-Fisher and all reviewers!

@Jim-215-Fisher Jim-215-Fisher deleted the Distribution-Exponential branch January 5, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewers needed This patch requires extra eyes topic: statistics Statistical functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants