Modification of the function parse_mode in stdlib_experimental_io

[jvdp1]

I modified the function parse_mode in stdlib_experimental_io.f90 to be more flexible.
I also added a new test file test_parse_mode.f90 and removed associated tests from test_open (in case we would use a public parse_mode only for tests).
I added several cases for testing parse_mode.

[certik]

+1 from me to merge

…

On Sat, Jan 4, 2020, at 4:08 PM, Jeremie Vandenplas wrote: I modified the function `parse_mode` in `stdlib_experimental_io.f90` to be more flexible. I also added a new test file `test_parse_mode.f90` and removed associated tests from `test_open` (in case we would use a public `parse_mode` only for tests). I added several cases for testing `parse_mode`. You can view, comment on, or merge this pull request online at: #77 Commit Summary * modification of parse_mode + separation of test_open and test_parse_mode (+additional tests) * renamed test_parse_mode subroutine for consistency File Changes * *M* src/stdlib_experimental_io.f90 <https://github.com/fortran-lang/stdlib/pull/77/files#diff-0> (37) * *M* src/tests/io/CMakeLists.txt <https://github.com/fortran-lang/stdlib/pull/77/files#diff-1> (5) * *M* src/tests/io/Makefile.manual <https://github.com/fortran-lang/stdlib/pull/77/files#diff-2> (1) * *M* src/tests/io/test_open.f90 <https://github.com/fortran-lang/stdlib/pull/77/files#diff-3> (44) * *A* src/tests/io/test_parse_mode.f90 <https://github.com/fortran-lang/stdlib/pull/77/files#diff-4> (171) Patch Links: * https://github.com/fortran-lang/stdlib/pull/77.patch * https://github.com/fortran-lang/stdlib/pull/77.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#77?email_source=notifications&email_token=AAAFAWFDO6YKOP7ERLLRKKTQ4EJILA5CNFSM4KCYMGO2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IEBJACQ>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAFAWFUWZW4OPNEFD54RITQ4EJILANCNFSM4KCYMGOQ>.

[certik]

This does not change any public API and improves the implementation and adds tests. So I am going to go ahead and merge this.

[certik]

@jvdp1 thanks, it looks great! The only additional improvement that I can think of is if something calls it like this open(filename, "rr"). In Python this gives an error if "r" and other modes are used more than once. Also some other combinations are probably not allowed, like "rw", or "rtb". But as it is now, it's already very useful.

[jvdp1]

@jvdp1 thanks, it looks great! The only additional improvement that I can think of is if something calls it like this open(filename, "rr"). In Python this gives an error if "r" and other modes are used more than once. Also some other combinations are probably not allowed, like "rw", or "rtb". But as it is now, it's already very useful.

Things like "rr" is not a problem, while things like "rw" are a problem. I will have a look to modify parse_mode to give an error when these cases are provided.

Edit: This should be solved with #82