Fix: copy_a
deallocation in determinant
#815
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a typo in
det
that does not deallocate the internal pointer matrix properly: it should be when the temporary is created (copy_a==.true.
):stdlib/src/stdlib_linalg_determinant.fypp
Line 227 in 206f84a
I don't know why an error was never printed in the tests, as it should be impossible to deallocate the target
of a pointer, if this is not
allocatable
.Anyways this is a fix for it, plus an additional test.
cc: @jvdp1 @jalvesz