-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doc comment #250
Add doc comment #250
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @k-nasa! Some of this conflicts with the recent #252 and the upcoming #255. I also added some doc (but only the crate level ones) during the restructure. Would you be willing to rebase after that?
Or alternatively, since you had done this before #255 if you could just rebase it on master, I can rebase #255 over this.
@prasannavl It seems that #255 has been approved. I will rebase after merge #255. |
@fairingrey I did rebase! Please give a review if you have time. 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic, thanks!
Description
I added a document.
I think that there is an inappropriate expression or wording, or an error in English, so please give me a review.
Motivation and Context
close: #244
How Has This Been Tested?
I generated a document and confirmed that there was no warning
Types of changes
Checklist: