-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds texture and scale randomization event terms #2121
Conversation
|
||
# Create the omni-graph node for the randomization term | ||
def rep_texture_randomization(): | ||
prims_group = rep.get.prims(path_pattern=f"{asset_entity.cfg.prim_path}/{body_names_regex}/visuals") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm since "visuals" is something hardcoded, I think it isn't great as we asume asset structure here. Should we make an attribute child_prim_paths
and let user specify the exact mesh paths they want to be modifying?
For example:
- For cubes, this will be
["geometry/mesh"]
- For articulations this will be
"[body_A/visuals", "body_B/visuals]"
@@ -0,0 +1,345 @@ | |||
# Copyright (c) 2022-2025, The Isaac Lab Project Developers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can combine the two into a single test fixture with the event terms. Might make it easier to add new tests later instead of copying code for just function everytime :)
As discussed with @hapatel-bdai there are few things we need to iron out but since those are NITs at this point, we'll go ahead with merging this MR as we are approaching a code freeze. |
Description
Type of change
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there