Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds texture and scale randomization event terms #2121

Merged
merged 3 commits into from
Mar 25, 2025

Conversation

hapatel-bdai
Copy link
Collaborator

Description

  • Added back texture randomization event term
  • Carrying over texture randomization and scale randomization unit tests from previous PRs
  • Added additional replicate physics failure case test

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@hapatel-bdai hapatel-bdai requested a review from Mayankm96 March 21, 2025 15:37

# Create the omni-graph node for the randomization term
def rep_texture_randomization():
prims_group = rep.get.prims(path_pattern=f"{asset_entity.cfg.prim_path}/{body_names_regex}/visuals")
Copy link
Contributor

@Mayankm96 Mayankm96 Mar 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm since "visuals" is something hardcoded, I think it isn't great as we asume asset structure here. Should we make an attribute child_prim_paths and let user specify the exact mesh paths they want to be modifying?

For example:

  • For cubes, this will be ["geometry/mesh"]
  • For articulations this will be "[body_A/visuals", "body_B/visuals]"

@@ -0,0 +1,345 @@
# Copyright (c) 2022-2025, The Isaac Lab Project Developers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can combine the two into a single test fixture with the event terms. Might make it easier to add new tests later instead of copying code for just function everytime :)

@Mayankm96 Mayankm96 changed the title Texture randomization event term, Texture and Scale randomization unit tests Adds texture and scale randomization event terms Mar 23, 2025
@Mayankm96
Copy link
Contributor

As discussed with @hapatel-bdai there are few things we need to iron out but since those are NITs at this point, we'll go ahead with merging this MR as we are approaching a code freeze.

@Mayankm96 Mayankm96 merged commit 324bb8c into main Mar 25, 2025
4 of 5 checks passed
@Mayankm96 Mayankm96 deleted the hpatel/scale_texture_randomization_test branch March 25, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants