-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add body_incoming_joint_wrench_b to ArticulationData field #2128
Open
jtigue-bdai
wants to merge
5
commits into
main
Choose a base branch
from
jat/feat/articulation_joint_reaction_wrench
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+116
−4
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
fcbeb81
add body_joint_reaction_wrench_b data field
jtigue-bdai 2b28c46
Apply suggestions from code review
jtigue-bdai 15dd8fc
update name and doc
jtigue-bdai 1bf207b
fix articulation tests
jtigue-bdai 7fa26aa
Merge branch 'main' into jat/feat/articulation_joint_reaction_wrench
jtigue-bdai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe useful to link to this documentation
Also the wording seems slightly confusing. The forces are in CoM frame or link frame? We have been using "_b" for link frame so if it not the latter, we should use something else I feel.
NIT: body joint reaction wrench seems a strange name to call it? Might be simpler to call it
body_reaction_wrench
orbody_incoming_wrench
🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah documentation link is good. The output is the force/torque at a joint in the bodies link frame orientation (need to double check if it's the parent or child body).
Yeah I don't really like it either. I went back and forth on the naming. There are as many wrenches as bodies but they are the result of wrenches imparted at joints. I'm down for other names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about
body_incoming_joint_wrench_b
that way it stays a bit more in convention with the physx documentation?