fix get_client #32
Merged
fix get_client #32
+99
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrifiro
commented
Jan 5, 2023
| @@ -113,19 +113,19 @@ async def get_client( | |||
| # data blobs. We remove the total timeout, and only limit the time | |||
| # that is spent when connecting to the remote server and waiting | |||
| # for new data portions. | |||
| connect_timeout = kwargs.get("connect_timeout", self.REQUEST_TIMEOUT) | |||
| connect_timeout = kwargs.pop("connect_timeout", self.REQUEST_TIMEOUT) | |||
There was a problem hiding this comment.
Use pop everywhere to avoid passing kwargs to client
dtrifiro
commented
Jan 5, 2023
| assert headers[header] == password | ||
|
|
||
|
|
||
| def test_ssl_verify_disable(): |
There was a problem hiding this comment.
Modified test_ssl_verify_{disable,custom_cert} to account for changes in #28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_client