refactor: use explicit client keyword arguments #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've refactored client keyword arguments to use explicit ones instead of mixing those with
**kwargs
, which has a few advantages:timeout
argument inHTTPFileSystem.__init__()
was a dummy because the HTTP(S) config schemas don't declare atimeout
setting, neither viaREMOTE_COMMON
nor viaHTTP_COMMON
.HTTPFileSystem.get_client()
, introduced in fix get_client #32, is dirty because it's a side-effect whose "correctness" may depend on order of execution. With the change in this PR, it works without a side-effect.