Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify plugin dependency declarations #299

Merged
merged 9 commits into from
Nov 1, 2022
Merged

Simplify plugin dependency declarations #299

merged 9 commits into from
Nov 1, 2022

Conversation

MarkEWaite
Copy link
Contributor

Simplify dependency declarations

  • Manage subversion dependency version from bom
  • Remove unused workflow-cps exclusion
  • Remove unused matrix-auth exclusion
  • Remove unused mockito-core exclusion
  • Remove unused awaitility exclusion
  • Use error_prone_annotations version from bom
  • Use commons-lang3 version from bom
  • Use spotbugs-annotations version from bom
  • Use access-modifier-annotation from parent

Remove dependency declarations and exclusions that are no longer required now that bill of materials is being used.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Sorry, something went wrong.

@MarkEWaite MarkEWaite enabled auto-merge (squash) October 30, 2022 18:12
@MarkEWaite
Copy link
Contributor Author

Needs #302 to fix the CI job on the master branch

@MarkEWaite MarkEWaite closed this Oct 31, 2022
auto-merge was automatically disabled October 31, 2022 02:29

Pull request was closed

@MarkEWaite MarkEWaite deleted the manage-deps-with-bom branch October 31, 2022 02:29
@MarkEWaite MarkEWaite restored the manage-deps-with-bom branch October 31, 2022 02:31
@MarkEWaite MarkEWaite reopened this Oct 31, 2022
@MarkEWaite MarkEWaite enabled auto-merge October 31, 2022 02:54
@MarkEWaite MarkEWaite requested a review from olamy October 31, 2022 04:44
@MarkEWaite MarkEWaite merged commit 0a42987 into jenkinsci:master Nov 1, 2022
@MarkEWaite MarkEWaite deleted the manage-deps-with-bom branch November 1, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants