Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Java 17 in CI #302

Merged
merged 3 commits into from
Oct 31, 2022
Merged

Conversation

MarkEWaite
Copy link
Contributor

Disable Java 17 in CI

  • Use useContainerAgent instead of useAci in Jenkinsfile
  • Use single quoted strings in Jenkinsfile
  • Do not test JDK 17 in CI

Java 17 fails tests because it is attempting to serialize mockito objects in a way that Java 17 appears to not allow. Needs fixes before Java 17 is enabled in CI.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@MarkEWaite
Copy link
Contributor Author

#297 enabled Java 17. I had not run the plugin tests with Java 17. The CI shows that the plugin needs fixes to its tests on Java 17. Remove the Java 17 testing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant