This repository was archived by the owner on Feb 14, 2024. It is now read-only.
Provide a way for Voici to pin packages #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jtpio
reviewed
Jul 24, 2023
| @@ -52,6 +52,10 @@ class XeusPythonEnv(FederatedExtensionAddon): | |||
| description="The path or URL to the empack config file", | |||
| ) | |||
|
|
|||
| pin_packages = PackagesList([]).tag( | |||
There was a problem hiding this comment.
Why was packages not enough for Voici?
Also regarding the name, how about extra_packages so it's coherent with other config options?
There was a problem hiding this comment.
Why was packages not enough for Voici?
Because it can (and it will) be overwritten by users.
This property I added should not be part of the config/public API.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help resolve the issue that Voici needs a specific ipywidgets lab extension in the page