Skip to content
This repository was archived by the owner on Feb 14, 2024. It is now read-only.

Provide a way for Voici to pin packages #139

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Provide a way for Voici to pin packages #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c926d17
Provide a way for Voici to pin packages
martinRenou Jul 20, 2023
ac6ad08
Fix Python version
martinRenou Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
- name: Install Python
uses: actions/setup-python@v2
with:
python-version: '3.8'
python-version: '3.10'
architecture: 'x64'
- uses: actions/download-artifact@v2
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Install Python
uses: actions/setup-python@v2
with:
python-version: 3.9
python-version: '3.10'
architecture: 'x64'
- name: Install node
uses: actions/setup-node@v2
Expand Down
6 changes: 5 additions & 1 deletion jupyterlite_xeus_python/env_build_addon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ class XeusPythonEnv(FederatedExtensionAddon):
description="The path or URL to the empack config file",
)

pin_packages = PackagesList([]).tag(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was packages not enough for Voici?

Also regarding the name, how about extra_packages so it's coherent with other config options?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was packages not enough for Voici?

Because it can (and it will) be overwritten by users.

This property I added should not be part of the config/public API.

description="This property is not supposed to be used, unless you know what you're doing.",
)

packages = PackagesList([]).tag(
config=True,
description="A comma-separated list of packages to install in the xeus-python env",
Expand All @@ -78,7 +82,7 @@ def post_build(self, manager):

env_prefix = build_and_pack_emscripten_env(
xeus_python_version=self.xeus_python_version,
packages=self.packages,
packages=[*self.packages, *self.pin_packages],
environment_file=Path(self.manager.lite_dir) / self.environment_file,
empack_config=self.empack_config,
output_path=self.cwd.name,
Expand Down