-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update-viem-wagmi #1771
chore: update-viem-wagmi #1771
Conversation
WalkthroughThe changes involve downgrading the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🔇 Additional comments (2)kleros-sdk/package.json (2)
The same version should be used across all packages in the monorepo to avoid potential compatibility issues. Let's verify version consistency: Also applies to: 52-52
The PR objectives mention upgrading to Let's verify the compatibility and potential issues: Also applies to: 52-52 ✅ Verification successfulLet me gather more information about the specific version requirements and usage in the codebase. Based on the gathered information, I can now provide a final response: Downgrading viem to v2.21.48 is consistent with the codebase The version downgrade to
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check viem version compatibility with wagmi and any known issues
# Check wagmi's peer dependencies for viem
gh api graphql -f query='
{
repository(owner: "wagmi-dev", name: "wagmi") {
object(expression: "main") {
... on Commit {
file(path: "package.json") {
object {
... on Blob {
text
}
}
}
}
}
}
}'
# Check for issues in viem between 2.21.48 and 2.21.53
gh api graphql -f query='
{
repository(owner: "wagmi-dev", name: "viem") {
issues(first: 10, filterBy: {states: CLOSED, labels: ["bug"]}) {
nodes {
title
body
closedAt
labels(first: 5) {
nodes {
name
}
}
}
}
}
}'
Length of output: 5747 Script: #!/bin/bash
# Check for viem usage and version requirements in the codebase
rg "viem.*['\"]" -g "package.json" --json
# Check if there are any imports or specific viem features being used
rg "from ['\"](viem|@viem)" --type ts --type js -A 2
Length of output: 22236 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for kleros-v2-testnet-devtools ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kleros-v2-university ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kleros-v2-neo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kleros-v2-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
e2c5544
to
2257bd0
Compare
Code Climate has analyzed commit 2257bd0 and detected 0 issues on this pull request. View more on Code Climate. |
|
PR-Codex overview
This PR focuses on downgrading the version of the
viem
package across multiple files to^2.21.48
from^2.21.53
.Detailed summary
web/package.json
,viem
version updated to^2.21.48
.kleros-sdk/package.json
,viem
version updated to^2.21.48
in bothdependencies
andpeerDependencies
.yarn.lock
,viem
version updated to^2.21.48
.viem@npm:^2.21.53
entry fromyarn.lock
.Summary by CodeRabbit
viem
dependency version in both the web and SDK packages to enhance stability.