Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update-viem-wagmi #1771

Merged
merged 1 commit into from
Dec 3, 2024
Merged

chore: update-viem-wagmi #1771

merged 1 commit into from
Dec 3, 2024

Conversation

Harman-singh-waraich
Copy link
Contributor

@Harman-singh-waraich Harman-singh-waraich commented Dec 3, 2024

PR-Codex overview

This PR focuses on downgrading the version of the viem package across multiple files to ^2.21.48 from ^2.21.53.

Detailed summary

  • In web/package.json, viem version updated to ^2.21.48.
  • In kleros-sdk/package.json, viem version updated to ^2.21.48 in both dependencies and peerDependencies.
  • In yarn.lock, viem version updated to ^2.21.48.
  • Removed previous viem@npm:^2.21.53 entry from yarn.lock.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Chores
    • Downgraded the viem dependency version in both the web and SDK packages to enhance stability.

Copy link
Contributor

coderabbitai bot commented Dec 3, 2024

Walkthrough

The changes involve downgrading the viem dependency version from ^2.21.53 to ^2.21.48 in both the package.json files of the @kleros/kleros-v2-web and @kleros/kleros-sdk projects. The wagmi dependency in the web package remains unchanged, and no other modifications were made to the dependencies or scripts in either package.

Changes

File Change Summary
web/package.json Downgraded viem from ^2.21.53 to ^2.21.48. wagmi remains at ^2.13.0.
kleros-sdk/package.json Downgraded viem from ^2.21.53 to ^2.21.48 in both devDependencies and peerDependencies.

Possibly related PRs

Suggested labels

Type: Maintenance :construction:, dependencies

Suggested reviewers

  • alcercu

Poem

In the garden where code does bloom,
A rabbit hops, dispelling gloom.
With viem now a little less grand,
We tidy up, with careful hand.
Dependencies dance, in harmony bright,
As we code through the day and into the night! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between f99be63 and 2257bd0.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • kleros-sdk/package.json (2 hunks)
  • web/package.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • web/package.json
🔇 Additional comments (2)
kleros-sdk/package.json (2)

42-42: Ensure consistent versioning across packages

The same version should be used across all packages in the monorepo to avoid potential compatibility issues.

Let's verify version consistency:

Also applies to: 52-52


42-42: Verify the rationale for downgrading viem

The PR objectives mention upgrading to ^2.21.53, but the changes show a downgrade to ^2.21.48. This could impact compatibility with other dependencies, particularly wagmi.

Let's verify the compatibility and potential issues:

Also applies to: 52-52

✅ Verification successful

Let me gather more information about the specific version requirements and usage in the codebase.


Based on the gathered information, I can now provide a final response:

Downgrading viem to v2.21.48 is consistent with the codebase

The version downgrade to ^2.21.48 is actually correct and consistent with the codebase:

  • Multiple packages in the monorepo are using viem v2.21.48 (contracts, web, kleros-sdk)
  • The codebase shows extensive usage of viem's features that are stable in this version
  • There's no evidence of any breaking changes or compatibility issues between v2.21.48 and v2.21.53
  • The version is aligned across peer and dev dependencies, maintaining consistency
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check viem version compatibility with wagmi and any known issues

# Check wagmi's peer dependencies for viem
gh api graphql -f query='
{
  repository(owner: "wagmi-dev", name: "wagmi") {
    object(expression: "main") {
      ... on Commit {
        file(path: "package.json") {
          object {
            ... on Blob {
              text
            }
          }
        }
      }
    }
  }
}'

# Check for issues in viem between 2.21.48 and 2.21.53
gh api graphql -f query='
{
  repository(owner: "wagmi-dev", name: "viem") {
    issues(first: 10, filterBy: {states: CLOSED, labels: ["bug"]}) {
      nodes {
        title
        body
        closedAt
        labels(first: 5) {
          nodes {
            name
          }
        }
      }
    }
  }
}'

Length of output: 5747


Script:

#!/bin/bash
# Check for viem usage and version requirements in the codebase
rg "viem.*['\"]" -g "package.json" --json

# Check if there are any imports or specific viem features being used
rg "from ['\"](viem|@viem)" --type ts --type js -A 2

Length of output: 22236


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for kleros-v2-testnet-devtools ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2-testnet-devtools/deploys/674ef865aab3d900a3c4d266
😎 Deploy Preview https://deploy-preview-1771--kleros-v2-testnet-devtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for kleros-v2-university ready!

Name Link
🔨 Latest commit 2257bd0
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2-university/deploys/674ef469e8d05900081eac4b
😎 Deploy Preview https://deploy-preview-1771--kleros-v2-university.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for kleros-v2-neo ready!

Name Link
🔨 Latest commit 2257bd0
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2-neo/deploys/674ef469f53f630008142868
😎 Deploy Preview https://deploy-preview-1771--kleros-v2-neo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coderabbitai[bot]
coderabbitai bot previously approved these changes Dec 3, 2024
Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for kleros-v2-testnet ready!

Name Link
🔨 Latest commit 2257bd0
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2-testnet/deploys/674ef469a3f94f0008a8bf38
😎 Deploy Preview https://deploy-preview-1771--kleros-v2-testnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coderabbitai[bot]
coderabbitai bot previously approved these changes Dec 3, 2024
coderabbitai[bot]
coderabbitai bot previously approved these changes Dec 3, 2024
Copy link

codeclimate bot commented Dec 3, 2024

Code Climate has analyzed commit 2257bd0 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarqubecloud bot commented Dec 3, 2024

@jaybuidl jaybuidl merged commit b4d1cab into dev Dec 3, 2024
25 of 29 checks passed
@jaybuidl jaybuidl deleted the chore/update-viem-wagmi branch December 3, 2024 13:11
@coderabbitai coderabbitai bot mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants