-
Notifications
You must be signed in to change notification settings - Fork 325
Friendly Load Balancer Names and Adopting Existing Load Balancers #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Is there anything blocking such an implementation, or does this just require someone to send in a PR for the functionality? |
Think it's just the contribution, given we're positioning this such that we don't need to maintain backwards compatibility |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
👀 /remove-lifecycle stale |
FWIW, I added support in aws-load-balancer-controller to specify a custom NLB name: kubernetes-sigs/aws-load-balancer-controller#1880 I've also confirmed that the controller can "adopt" existing NLBs by adding the appropriate tags to the load balancer and target groups: https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/efe7e71d270e57a70d0c17587ee89237e055ee4d/pkg/deploy/tracking/provider.go#L9-L24 I may open a docs PR that outlines the process. |
I've started working on this. |
/assign |
Need to figure out how to handle existing ELBs. |
Whats the current status? |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
Hi guys! Issue seems to be stuck, correct? |
is this working? |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
/remove-lifecycle rotten |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What would you like to be added:
Continuation of kubernetes/kubernetes#29789 which is closed because of deprecation of in-tree providers:
Why is this needed:
Deletion for a Service Type of Load Balancer is a common occurrence, being able to adopt existing load balancers and give them easy to read names will greatly enhance the user experience of kubernetes on AWS.
Also adding in comment from @KIVagant as it's a very popular one:
/kind feature
The text was updated successfully, but these errors were encountered: