Skip to content

Tracking issue for v2 aws provider #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks
andrewsykim opened this issue Sep 15, 2020 · 12 comments
Closed
4 tasks

Tracking issue for v2 aws provider #125

andrewsykim opened this issue Sep 15, 2020 · 12 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@andrewsykim
Copy link
Member

andrewsykim commented Sep 15, 2020

What would you like to be added:
In #114 we added the initial boilerplate code to enable a v2 AWS cloud provider. This is a tracking issue for future PRs that add to the implementation.

Why is this needed:
This project will continue to support the existing AWS provider in "out-of-tree" mode. However, there are many known issues and gaps in the current provider implementation that is not trivial to address. A new v2 implementation will try to address these limitations. The v2 implementation is a breaking change from v1 and is only supported for new clusters. Existing clusters cannot upgrade to v1.

  • Instances (@andrewsykim)
  • Zones
  • LoadBalancer (@HaibaraAi96)
  • Routes

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 15, 2020
@andrewsykim
Copy link
Member Author

andrewsykim commented Sep 15, 2020

/assign

Hoping to have some PRs open for this in the next week or so

@andrewsykim
Copy link
Member Author

Some issues we should consider as we implement v2:
#124
#63
#55

@nicolehanjing
Copy link
Member

I'd love to work on the loadbalancer implementation 😃

@andrewsykim
Copy link
Member Author

Sounds good @HaibaraAi96! I updated the tracking issue to break up the work here a bit and assigned the loadbalancer implementation to you. Feel free to use the legacy implementation as a reference https://github.com/kubernetes/kubernetes/tree/master/staging/src/k8s.io/legacy-cloud-providers/aws

@andrewsykim
Copy link
Member Author

/assign @HaibaraAi96

@rfranzke
Copy link
Contributor

The v2 implementation is a breaking change from v1 and is only supported for new clusters. Existing clusters cannot upgrade to v1.

What does this mean exactly, i.e., how will existing clusters be upgraded in the future (assuming the legacy AWS cloud provider code is being removed from k/k)?

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 19, 2021
@nckturner
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 8, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 9, 2021
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 8, 2021
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

6 participants