add initial experimental v2 AWS cloud provider #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
approved
Signed-off-by: Andrew Sy Kim <[email protected]>
|
/hold Requires discussion |
k8s-ci-robot
added
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
We discussed this in the aws-provider biweekly ; there are fragmentation risks but I agree that they are outweighed by the unblocking nature of a v2. Then we can see if the changes need to be breaking (and are worth the breakage!) /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsykim, justinsb, nckturner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Sy Kim [email protected]
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds an initial implementation of an experimental v2 provider that is exclusively out-of-tree. The actual implementation is incomplete, this just adds the initial boilerplate code for the cloud provider interface. Future PRs will incrementally implement the entire interface.
There are many requested features about the existing AWS cloud provider that are difficult to implement since we can't break behavior against existing clusters. Some of these include but are not limited to:
In addition, the existing provider is catered towards the deprecated in-tree architecture where it relies on the kubelet, kube-controller-manager and kube-apiserver to be AWS aware. As we approach a future of only out-of-tree providers, starting fresh on a v2 provider under these new assumptions may be the right direction. The v2 provider would be a breaking change from v1, meaning existing clusters shouldn't migrate to the v2 provider. The v2 provider will only support new clusters that enable the out-of-tree cloud provider (i.e. setting --cloud-provider=external on kube components). The v1 provider is NOT being deprecated and will continue to be supported in this repo. However, a future version of Kubernetes will remove the in-tree provider from the core Kubernetes release.
Does this PR introduce a user-facing change?: