Skip to content

Create a new instance of aws cloud #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2020
Merged

Create a new instance of aws cloud #129

merged 1 commit into from
Sep 24, 2020

Conversation

nicolehanjing
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR creates a new instance of aws cloud, which helps future PRs to commit in parallel with fewer conflicts

Which issue(s) this PR fixes:

Part of #125

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Create a new instance of aws cloud of v2 provider.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 23, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @HaibaraAi96. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 23, 2020
@nicolehanjing
Copy link
Member Author

/assign @andrewsykim

andrewsykim
andrewsykim reviewed Sep 23, 2020
View reviewed changes
pkg/providers/v2/interface.go Outdated
@@ -41,6 +48,86 @@ var _ cloudprovider.Interface = (*cloud)(nil)
type cloud struct {
}

type awsSDKProvider struct {
creds *credentials.Credentials
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we need a new type like awsSDKProvider yet, seems premature. Can we have creds and the region field be in cloud instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that sounds reasonable, will update!

pkg/providers/v2/interface.go

// Derives the region from a valid az name.
// Returns an error if the az is known invalid (empty)
func azToRegion(az string) (string, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a unit test for this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, will add soon!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewsykim Updated!
I add a new file called interface_test.go and include the unit test for it
I also delete the type awsSDKProvider and call metadataClient directly in newCloud()

@nicolehanjing nicolehanjing force-pushed the nicoleh-cloudinitialization branch from d61dc55 to 564146c Compare September 23, 2020 21:17
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 23, 2020
andrewsykim
andrewsykim reviewed Sep 23, 2020
View reviewed changes
pkg/providers/v2/interface.go
@@ -39,6 +46,71 @@ var _ cloudprovider.Interface = (*cloud)(nil)

// cloud is the AWS v2 implementation of the cloud provider interface
type cloud struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 36 above needs to be updated to call newCloud as part of RegisterCloudProvider

andrewsykim
andrewsykim reviewed Sep 23, 2020
View reviewed changes
Copy link
Member

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

pkg/providers/v2/interface.go Outdated
}

// newCloud creates a new instance of AWSCloud.
func newCloud() (*cloud, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should return the interface it implements instead

func newCloud() (cloudprovider.Interface, error)

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 23, 2020
@nicolehanjing nicolehanjing force-pushed the nicoleh-cloudinitialization branch from 564146c to 60c7fa0 Compare September 23, 2020 21:58
@nicolehanjing
Copy link
Member Author

/retest

@nicolehanjing nicolehanjing force-pushed the nicoleh-cloudinitialization branch from 60c7fa0 to a3ccd4a Compare September 23, 2020 22:28
nicolehanjing
nicolehanjing commented Sep 24, 2020
View reviewed changes
pkg/providers/v2/cloud.go
cloudprovider "k8s.io/cloud-provider"
)

func init() {
cloudprovider.RegisterCloudProvider(ProviderName, func(config io.Reader) (cloudprovider.Interface, error) {
return &cloud{}, nil
return newCloud()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewsykim updated!
Also passed the unit test, let me know if you have any other suggestions :)

andrewsykim
andrewsykim reviewed Sep 24, 2020
View reviewed changes
Copy link
Member

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

thanks @nicolehanjing

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, nicolehanjing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2020
@k8s-ci-robot k8s-ci-robot merged commit 211d51d into kubernetes:master Sep 24, 2020
@nicolehanjing nicolehanjing mentioned this pull request Oct 8, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim andrewsykim left review comments

@leakingtapan leakingtapan Awaiting requested review from leakingtapan

@nckturner nckturner Awaiting requested review from nckturner

Assignees

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolehanjing @k8s-ci-robot @andrewsykim