Skip to content

[Merged by Bors] - chore: adaptations for lean4#5542 #17564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

kmill
Copy link
Contributor

@kmill kmill commented Oct 9, 2024

In lean4#5542 we are deprecating inductive ... :=, structure ... :=, and class ... := for their ... where counterparts.


Open in Gitpod

In lean4#5542 we are deprecating `inductive ... :=`,
`structure ... :=`, and `class ... :=` for their `... where` counterparts.
Copy link

github-actions bot commented Oct 9, 2024

PR summary 03bf4f6e67

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

-+-+-+-+-+ Hom
--++ IsCompatibleWithShift
------++++++--++ Equiv

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@grunweg
Copy link
Collaborator

grunweg commented Oct 9, 2024

I checked the entire diff (phew), and this PR does what is says, and aligns mathlib with an upcoming core change. Thanks!
maintainer merge

Copy link

github-actions bot commented Oct 9, 2024

🚀 Pull request has been placed on the maintainer queue by grunweg.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 9, 2024

✌️ kmill can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@kmill
Copy link
Contributor Author

kmill commented Oct 9, 2024

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Oct 9, 2024
mathlib-bors bot pushed a commit that referenced this pull request Oct 9, 2024
In [lean4#5542](leanprover/lean4#5542) we are deprecating `inductive ... :=`, `structure ... :=`, and `class ... :=` for their `... where` counterparts.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 9, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: adaptations for lean4#5542 [Merged by Bors] - chore: adaptations for lean4#5542 Oct 9, 2024
@mathlib-bors mathlib-bors bot closed this Oct 9, 2024
@mathlib-bors mathlib-bors bot deleted the adapt_for_lean_5542 branch October 9, 2024 09:42
mathlib-bors bot pushed a commit that referenced this pull request Oct 11, 2024
In [lean4#5542](leanprover/lean4#5542) we are deprecating `inductive ... :=`, `structure ... :=`, and `class ... :=` for their `... where` counterparts. Continuation of #17564.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants