chore: deprecate := variants of inductive and structure
#5542
+53
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Sep 30, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Sep 30, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Sep 30, 2024
leanprover-community-bot
added
the
breaks-mathlib
|
Mathlib CI status (docs):
|
Deprecates `inductive ... :=` and `structure ... :=`. Currently this syntax produces a warning, controlled by the `linter.deprecated` option. Part of leanprover#5236
kmill
force-pushed
the
deprecate-colon-eq
branch
from
106c348 to
89ba3be
Compare
|
Kyle, thanks for the heads up! I think that I never used |
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Oct 8, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 8, 2024
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 9, 2024
In [lean4#5542](leanprover/lean4#5542) we are deprecating `inductive ... :=`, `structure ... :=`, and `class ... :=` for their `... where` counterparts.
eric-wieser
pushed a commit
to leanprover-community/quote4
that referenced
this pull request
Oct 9, 2024
In leanprover/lean4#5542 we will be deprecating `structure ... :=` in favor of `structure ... where`.
kmill
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 11, 2024
In [lean4#5542](leanprover/lean4#5542) we are deprecating `inductive ... :=`, `structure ... :=`, and `class ... :=` for their `... where` counterparts.
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 11, 2024
In [lean4#5542](leanprover/lean4#5542) we are deprecating `inductive ... :=`, `structure ... :=`, and `class ... :=` for their `... where` counterparts. Continuation of #17564.
kmill
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 12, 2024
In [lean4#5542](leanprover/lean4#5542) we are deprecating `inductive ... :=`, `structure ... :=`, and `class ... :=` for their `... where` counterparts. Continuation of #17655.
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 13, 2024
In [lean4#5542](leanprover/lean4#5542) we are deprecating `inductive ... :=`, `structure ... :=`, and `class ... :=` for their `... where` counterparts. Continuation of #17655.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates
inductive ... :=,structure ... :=, andclass ... :=in favor of the... wherevariant. Currently this syntax produces a warning, controlled by thelinter.deprecatedoption.Breaking change: modifies
Lean.Linter.logLintIfto useLean.Linter.getLinterValueto determine if a linter value is set. This means that thelinter.alloption now is taken into account when the linter option is not set.Part of #5236