Skip to content

[Merged by Bors] - chore: more adaptations for lean4#5542 #17688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kmill
Copy link
Contributor

@kmill kmill commented Oct 12, 2024

In lean4#5542 we are deprecating inductive ... :=, structure ... :=, and class ... := for their ... where counterparts. Continuation of #17655.


Open in Gitpod

In [lean4#5542](leanprover/lean4#5542) we are deprecating `inductive ... :=`, `structure ... :=`, and `class ... :=` for their `... where` counterparts. Continuation of #17655.
@kmill kmill added the easy < 20s of review time. See the lifecycle page for guidelines. label Oct 12, 2024
Copy link

PR summary 8cc4435411

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

@kim-em
Copy link
Contributor

kim-em commented Oct 13, 2024

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Oct 13, 2024
mathlib-bors bot pushed a commit that referenced this pull request Oct 13, 2024
In [lean4#5542](leanprover/lean4#5542) we are deprecating `inductive ... :=`, `structure ... :=`, and `class ... :=` for their `... where` counterparts. Continuation of #17655.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 13, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: more adaptations for lean4#5542 [Merged by Bors] - chore: more adaptations for lean4#5542 Oct 13, 2024
@mathlib-bors mathlib-bors bot closed this Oct 13, 2024
@mathlib-bors mathlib-bors bot deleted the kmill_more_colon_eq branch October 13, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants