feat: adds optConfig syntax for tactic configuration
#5883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR just adds the syntax and elaborator for a new kind of tactic configuration.
Once tactics switch over to it, rather than writing `simp (config := { contextual := true, maxSteps := 22})`, one can write `simp +contextual (maxSteps := 22)`.
Note to metaprogrammers: Use `optConfig` instead of `(config)?`. The elaborator generated by `declare_config_elab` accepts both old and new configurations. The elaborator has also been written to be tolerant to null nodes, so adapting to `optConfig` should be as easy as changing just the syntax for your tactics.
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Oct 30, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 30, 2024
|
Mathlib CI status (docs):
|
leanprover-community-bot
added
the
breaks-mathlib
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Oct 30, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 30, 2024
leanprover-community-bot
added
builds-mathlib
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 1, 2024
PR #5883 added a new syntax for tactic configuration, and this PR enables it in most tactics. Example: `simp +contextual`. There will be followup PRs to modify the remaining ones. Breaking change: Tactics that are macros for `simp` or other core tactics need to adapt. The easiest way is to replace `(config)?` with `optConfig` and then in the syntax quotations replace `$[$cfg]?` by `$cfg:optConfig`. For tactics that manipulate the configuration, see `erw` for an example: ```lean macro "erw" c:optConfig s:rwRuleSeq loc:(location)? : tactic => do `(tactic| rw $[$(getConfigItems c)]* (transparency := .default) $s:rwRuleSeq $(loc)?) ``` Configuration options are processed left-to-right, so this forces the `transparency` to always be `.default`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new syntax for tactic and command configurations. It also updates the elaborator construction command to be able to process this new syntax.
We do not update core tactics yet. Once tactics switch over to it, rather than (for example) writing
simp (config := { contextual := true, maxSteps := 22}), one can writesimp +contextual (maxSteps := 22). The new syntax is reverse compatible in the sense that(config := ...)still sets the entire configuration.Note to metaprogrammers: Use
optConfiginstead of(config)?. The elaborator generated bydeclare_config_elabaccepts both old and new configurations. The elaborator has also been written to be tolerant to null nodes, so adapting tooptConfigshould be as easy as changing just the syntax for your tactics and deletingmkOptionalNode.Breaking change: The new system is mostly reverse compatible, however the type of the generated elaborator now lands in
TacticMto make use of the current recovery state. Commands that wish to elaborate configurations should now usedeclare_command_config_elabinstead ofdeclare_config_elabto get an elaborator landing inCommandElabM.