Add initial partner driver testing github action #9
Conversation
| uses: actions/setup-java@v2 | ||
| with: | ||
| distribution: temurin | ||
| java-version: 21 |
There was a problem hiding this comment.
we might want to test this on a few different versions: at least 11 and 21
There was a problem hiding this comment.
I think 21 should be sufficient for now, as we get more in the weeds having a mechanism for multiple java versions would make sense.
| - name: Setup Node | ||
| uses: actions/setup-node@v2 | ||
| with: | ||
| node-version: "22" |
There was a problem hiding this comment.
I think most of our stuff is still on node v18
| - name: Build jar | ||
| run: | | ||
| echo "{:deps {metabase/${{ inputs.DRIVER }} {:local/root \"${{ inputs.DRIVER }}\" }}}" > modules/drivers/deps.edn | ||
| bin/build-driver.sh ${{ inputs.DRIVER }} | ||
| mv resources/modules/${{ inputs.DRIVER }}.metabase-driver.jar ${{ inputs.DRIVER }}.${{ inputs.MB_REF }}.metabase-driver.jar | ||
|
|
||
| - name: Upload driver jar | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: ${{ inputs.DRIVER }}.${{ inputs.MB_REF }}.metabase-driver.jar | ||
| path: metabase/${{ inputs.DRIVER }}.${{ inputs.MB_REF }}.metabase-driver.jar |
There was a problem hiding this comment.
why are we saving these artifacts?
There was a problem hiding this comment.
The idea is to move towards us building and using the artifacts that we include in cloud rather than relying on partner builds.
| schedule: | ||
| - cron: "0 * * * *" |
There was a problem hiding this comment.
😳 running this every hour on the hour?
| on: | ||
| schedule: | ||
| - cron: "0 * * * *" | ||
| push: |
There was a problem hiding this comment.
I think all branches is actually correct, since PRs would affect the runners and should ensure everything is working (even if not passing)
| outputs: | ||
| versions: ${{ steps.versions.outputs.value }} | ||
| drivers: ${{ steps.drivers.outputs.value }} | ||
| steps: |
There was a problem hiding this comment.
little tip: you can set this once for the whole job at the job level, which also makes it easier to read:
env:
CURRENT_VERSION: ${{ vars.CURRENT_VERSION }}
There was a problem hiding this comment.
also, we should check and make sure this variable is an org-level variable, and not specific to each repo so we don't have to keep them in sync, which we will 100% fail to do at some point.
Runs metabase test suite against every driver in registry.yml
Can run local docker instances of driver dbs or use credentials in 1password to access hosted ci instances.
New
refskey can point from a metabase version, say53to a reference on the driver remote repo if needed.