Add initial partner driver testing github action #9
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,150 @@ | ||
| name: Test Partner Driver | ||
|
|
||
| on: | ||
| workflow_call: | ||
| inputs: | ||
| DRIVER: | ||
| description: 'Driver to use' | ||
| type: string | ||
| required: true | ||
| MB_REF: | ||
| type: string | ||
| required: true | ||
| PARTNER_REF: | ||
| type: string | ||
| required: true | ||
| REPO: | ||
| type: string | ||
| required: true | ||
| DOCKER: | ||
| type: boolean | ||
| required: true | ||
| secrets: | ||
| OP_SERVICE_ACCOUNT_TOKEN: | ||
| required: true | ||
|
|
||
| jobs: | ||
| run-tests: | ||
| timeout-minutes: 45 | ||
| runs-on: ubuntu-latest | ||
| defaults: | ||
| run: | ||
| working-directory: ./metabase | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| path: registry | ||
|
|
||
| - name: Checkout Metabase Repo | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| path: metabase | ||
| repository: metabase/metabase | ||
| ref: ${{ inputs.MB_REF }} | ||
|
|
||
| - name: Checkout Driver Repo | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| repository: ${{ inputs.REPO }} | ||
| path: metabase/modules/drivers/${{ inputs.DRIVER }} | ||
| ref: ${{ inputs.PARTNER_REF }} | ||
|
|
||
| - name: Set up JDK 21 | ||
| uses: actions/setup-java@v2 | ||
| with: | ||
| distribution: temurin | ||
| java-version: 21 | ||
|
|
||
| - name: Start Database in Docker | ||
| if: ${{ inputs.DOCKER }} | ||
| uses: hoverkraft-tech/[email protected] | ||
| with: | ||
| compose-file: "./registry/docker-compose.yml" | ||
| services: | | ||
| ${{ inputs.DRIVER }} | ||
|
|
||
| - name: Install Clojure CLI | ||
| run: | | ||
| curl -O https://download.clojure.org/install/linux-install-1.11.1.1262.sh && | ||
| sudo bash ./linux-install-1.11.1.1262.sh | ||
|
|
||
| - uses: 1password/install-cli-action@v1 | ||
|
|
||
| - name: Setup Node | ||
| uses: actions/setup-node@v2 | ||
| with: | ||
| node-version: "18" | ||
| cache: "yarn" | ||
| cache-dependency-path: ./metabase/yarn.lock | ||
|
|
||
| - name: Get M2 cache | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: | | ||
| ~/.m2 | ||
| ~/.gitlibs | ||
| key: ${{ runner.os }}-partner-driver-${{ hashFiles('**/deps.edn') }} | ||
|
|
||
| - name: Build static-viz | ||
| run: yarn build-static-viz | ||
|
|
||
| - name: Setup docker | ||
| if: ${{ inputs.DOCKER }} | ||
| run: | | ||
| sudo echo "127.0.0.1 ${{ inputs.DRIVER }}" | sudo tee -a /etc/hosts | ||
|
|
||
| - name: Run tests | ||
| run: | | ||
|
|
||
| export DRIVER=${{ inputs.DRIVER }} | ||
|
|
||
| # Setup environment | ||
| export OP_SERVICE_ACCOUNT_TOKEN=${{ secrets.OP_SERVICE_ACCOUNT_TOKEN }} | ||
| op item list --format=json --tags partner-testing \ | ||
| | jq -r ".[] | select(.title | test(\"driver: $DRIVER\")) | .id" \ | ||
| | xargs -I {} op item get {} --format=json --vault "Driver Development" \ | ||
| | jq -r ".fields[] | select(.section.label == \"ENV\") | \"MB_$(echo $DRIVER | tr '[:lower:]' '[:upper:]' | tr '-' '_')_TEST_\\(.label)=\\\"\\(.value)\\\"\"" \ | ||
| > driver.env | ||
|
|
||
| set -a | ||
| source driver.env | ||
| set +a | ||
| rm driver.env | ||
|
|
||
| # Move source in subdir to modules | ||
| DIR=$( yq -r ".drivers[] | select(.name == \"${DRIVER}\") | .test.dir" ../registry/registry.yaml ) | ||
| if [[ "$DIR" != "null" ]]; then | ||
| mv modules/drivers/${DRIVER} ../tmp-${DRIVER} | ||
| mv ../tmp-${DRIVER}/${DIR} modules/drivers/${DRIVER} | ||
| fi | ||
|
|
||
| # Run tests | ||
| DRIVERS=${{ inputs.DRIVER }} \ | ||
| clojure \ | ||
| -Sdeps "{:jvm-opts [\"-Dci=true\"] :aliases {:partner-driver {:extra-paths [\"modules/drivers/${{ inputs.DRIVER }}/test\" \"modules/driver/${{ inputs.DRIVER }}/src\"] :extra-deps {metabase/partner-driver {:local/root \"modules/drivers/${{ inputs.DRIVER }}\"}}}}}" \ | ||
| -X:dev:drivers:drivers-dev:ee:ee-dev:partner-driver:test \ | ||
| :only-tags [:mb/driver-tests] | ||
|
|
||
| - name: Build jar | ||
| run: | | ||
| echo "{:deps {metabase/${{ inputs.DRIVER }} {:local/root \"${{ inputs.DRIVER }}\" }}}" > modules/drivers/deps.edn | ||
| bin/build-driver.sh ${{ inputs.DRIVER }} | ||
| mv resources/modules/${{ inputs.DRIVER }}.metabase-driver.jar ${{ inputs.DRIVER }}.${{ inputs.MB_REF }}.metabase-driver.jar | ||
|
|
||
| - name: Upload driver jar | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: ${{ inputs.DRIVER }}.${{ inputs.MB_REF }}.metabase-driver.jar | ||
| path: metabase/${{ inputs.DRIVER }}.${{ inputs.MB_REF }}.metabase-driver.jar | ||
|
Comment on lines
+128
to
+138
There was a problem hiding this comment. why are we saving these artifacts? There was a problem hiding this comment. The idea is to move towards us building and using the artifacts that we include in cloud rather than relying on partner builds. |
||
|
|
||
| - name: Publish Test Report | ||
| uses: dorny/test-reporter@v1 | ||
| if: failure() | ||
| with: | ||
| path: "target/junit/**/*_test.xml" | ||
| name: JUnit Test Report ${{ inputs.DRIVER }} | ||
| working-directory: metabase | ||
| reporter: java-junit | ||
| list-suites: failed | ||
| list-tests: failed | ||
| fail-on-error: false | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| name: Test All Partner Drivers | ||
|
|
||
| on: | ||
| schedule: | ||
| - cron: "0 10 * * *" | ||
| push: | ||
|
There was a problem hiding this comment. I think all branches is actually correct, since PRs would affect the runners and should ensure everything is working (even if not passing) |
||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| setup: | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| versions: ${{ steps.versions.outputs.value }} | ||
| drivers: ${{ steps.drivers.outputs.value }} | ||
| env: | ||
| CURRENT_VERSION: ${{ vars.CURRENT_VERSION }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Install yq | ||
| run: sudo snap install yq | ||
| - id: drivers | ||
| run: | | ||
| echo value=$(yq ".drivers | map({\"name\": .name, \"repo\": .test.repo\ | ||
| , \"edge\": .test.refs.default\ | ||
| , \"current\": (.test.refs | omit([\"default\"]) | to_entries| .[] | select((.key|tonumber) >= $CURRENT_VERSION) | .value)//.test.refs.default\ | ||
| , \"previous\": (.test.refs | omit([\"default\"]) | to_entries| .[] | select((.key|tonumber) >= $(($CURRENT_VERSION - 1))) | .value)//.test.refs.default\ | ||
| , \"docker\": .test.docker})" -o json registry.yaml) >> $GITHUB_OUTPUT | ||
|
|
||
| - id: versions | ||
| run: | | ||
| echo "value=[{\"ref\": \"master\", \"name\": \"edge\"}, {\"ref\": \"release-x.${CURRENT_VERSION}.x\", \"name\": \"current\"}, {\"ref\": \"release-x.$(($CURRENT_VERSION - 1)).x\", \"name\": \"previous\"}]" >> $GITHUB_OUTPUT | ||
| - run: | | ||
| echo "versions ${{ fromJSON(steps.versions.outputs.value) }}" | ||
| echo "drivers ${{ fromJSON(steps.drivers.outputs.value) }}" | ||
|
|
||
| driver: | ||
| needs: [ setup ] | ||
| name: "${{ matrix.driver.name }} : ${{ matrix.version.name }} " | ||
| strategy: | ||
| matrix: | ||
| driver: ${{fromJSON(needs.setup.outputs.drivers)}} | ||
| version: ${{fromJSON(needs.setup.outputs.versions)}} | ||
| fail-fast: false | ||
| uses: ./.github/workflows/callable-partner-driver.yml | ||
| with: | ||
| MB_REF: ${{ matrix.version.ref }} | ||
| PARTNER_REF: ${{ matrix.driver[matrix.version.name] }} | ||
| DRIVER: ${{ matrix.driver.name }} | ||
| REPO: ${{ matrix.driver.repo }} | ||
| DOCKER: ${{ matrix.driver.docker }} | ||
| secrets: inherit | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| --- | ||
| version: "3.9" | ||
|
|
||
| services: | ||
| materialize: | ||
| image: materialize/materialized:latest | ||
| container_name: materialize | ||
| command: | ||
| - --availability-zone=test1 | ||
| - --availability-zone=test2 | ||
| - --bootstrap-role=materialize | ||
| - --system-parameter-default=max_tables=1000 | ||
| environment: | ||
| MZ_NO_TELEMETRY: 1 | ||
| ports: | ||
| - 6875:6875 | ||
| - 6877:6877 | ||
| - 6878:6878 | ||
| healthcheck: | ||
| { | ||
| test: curl -f localhost:6878/api/readyz, | ||
| interval: 1s, | ||
| start_period: 35s, | ||
| } | ||
| clickhouse: | ||
| image: clickhouse/clickhouse-server:latest | ||
| ports: | ||
| - 8123:8123 | ||
| - 9000:9000 | ||
| exasol: | ||
| image: exasol/docker-db:7.1.23 | ||
| ports: | ||
| - 8563:8563 | ||
| - 2580:2580 | ||
| - 443:443 | ||
| starburst: | ||
| image: trinodb/trino:latest | ||
| ports: | ||
| - 8082:8080 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might want to test this on a few different versions: at least 11 and 21
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 21 should be sufficient for now, as we get more in the weeds having a mechanism for multiple java versions would make sense.