Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSTEST0011: report if InheritanceBehavior.BeforeEachDerivedClass is set on a sealed class #3370

Merged
merged 10 commits into from
Jul 31, 2024
Merged

MSTEST0011: report if InheritanceBehavior.BeforeEachDerivedClass is set on a sealed class #3370

merged 10 commits into from
Jul 31, 2024

Conversation

engyebrahim
Copy link
Member

fix: #3349

Evangelink
Evangelink reviewed Jul 30, 2024
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for when behavior is set to None. Please also update PR title to use correct analyzer ID

@engyebrahim engyebrahim changed the title MSTEST11: report if InheritanceBehavior.BeforeEachDerivedClass is set on a sealed class MSTEST0011: report if InheritanceBehavior.BeforeEachDerivedClass is set on a sealed class Jul 31, 2024
Evangelink
Evangelink previously approved these changes Jul 31, 2024
View reviewed changes
@Evangelink Evangelink enabled auto-merge (squash) July 31, 2024 08:07
Evangelink
Evangelink previously approved these changes Jul 31, 2024
View reviewed changes
@engyebrahim engyebrahim mentioned this pull request Jul 31, 2024
Merged
@Evangelink Evangelink merged commit ea6195c into main Jul 31, 2024
6 checks passed
@Evangelink Evangelink deleted the Enji/fix-0011 branch July 31, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MSTEST11: report if InheritanceBehavior.BeforeEachDerivedClass is set on a sealed class
2 participants
@engyebrahim @Evangelink