MSTEST0011: report if InheritanceBehavior.BeforeEachDerivedClass is set on a sealed class

src/Analyzers/MSTest.Analyzers/ClassCleanupShouldBeValidAnalyzer.cs

@@ -59,7 +59,8 @@ private static void AnalyzeSymbol(SymbolAnalysisContext context, INamedTypeSymbo
             && (!methodSymbol.HasValidFixtureMethodSignature(taskSymbol, valueTaskSymbol, canDiscoverInternals, shouldBeStatic: true,
                 allowGenericType: isInheritanceModeSet, testContextSymbol: null,
                 testClassAttributeSymbol, fixtureAllowInheritedTestClass: true, out bool isFixable)
-                || (!isInheritanceModeSet && methodSymbol.ContainingType.IsAbstract)))
+                || (!isInheritanceModeSet && methodSymbol.ContainingType.IsAbstract)
+                || (isInheritanceModeSet && methodSymbol.ContainingType.IsSealed)))
         {
             context.ReportDiagnostic(isFixable
                 ? methodSymbol.CreateDiagnostic(Rule, methodSymbol.Name)

src/Analyzers/MSTest.Analyzers/Resources.resx

@@ -182,7 +182,8 @@
 - return type should be 'void', 'Task' or 'ValueTask'
 - not be 'async void'
 - not be a special method (finalizer, operator...)
--'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'.</value>
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should not be specified if the class is 'sealed'.</value>
   </data>
   <data name="ClassCleanupShouldBeValidMessageFormat" xml:space="preserve">
     <value>ClassCleanup method '{0}' signature is invalid</value>

src/Analyzers/MSTest.Analyzers/xlf/Resources.cs.xlf

@@ -110,8 +110,9 @@
 - return type should be 'void', 'Task' or 'ValueTask'
 - not be 'async void'
 - not be a special method (finalizer, operator...)
--'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'.</source>
-        <target state="translated">Aby byly metody s označením [ClassCleanup] platné, musí se řídit následujícím rozložením:
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should not be specified if the class is 'sealed'.</source>
+        <target state="needs-review-translation">Aby byly metody s označením [ClassCleanup] platné, musí se řídit následujícím rozložením:
 – mít hodnotu public 
 – nesmí mít hodnotu static
 – nesmí být obecné ani definované pro obecnou třídu

src/Analyzers/MSTest.Analyzers/xlf/Resources.de.xlf

@@ -109,8 +109,9 @@
 - return type should be 'void', 'Task' or 'ValueTask'
 - not be 'async void'
 - not be a special method (finalizer, operator...)
--'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'.</source>
-        <target state="translated">Methoden, die mit [ClassCleanup] gekennzeichnet sind, müssen dem folgenden Layout folgen, um gültig zu sein:
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should not be specified if the class is 'sealed'.</source>
+        <target state="needs-review-translation">Methoden, die mit [ClassCleanup] gekennzeichnet sind, müssen dem folgenden Layout folgen, um gültig zu sein:
 – "öffentlich" sein 
 – nicht "statisch" sein
 – nicht generisch oder für eine generische Klasse definiert sein

src/Analyzers/MSTest.Analyzers/xlf/Resources.es.xlf

@@ -109,8 +109,9 @@
 - return type should be 'void', 'Task' or 'ValueTask'
 - not be 'async void'
 - not be a special method (finalizer, operator...)
--'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'.</source>
-        <target state="translated">Los métodos marcados con [ClassCleanup] deben seguir el siguiente diseño para ser válidos:
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should not be specified if the class is 'sealed'.</source>
+        <target state="needs-review-translation">Los métodos marcados con [ClassCleanup] deben seguir el siguiente diseño para ser válidos:
 - ser "público" 
 - no ser "estático"
 - no ser genérico ni estar definido en una clase genérica

src/Analyzers/MSTest.Analyzers/xlf/Resources.fr.xlf

@@ -109,8 +109,9 @@
 - return type should be 'void', 'Task' or 'ValueTask'
 - not be 'async void'
 - not be a special method (finalizer, operator...)
--'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'.</source>
-        <target state="translated">Les méthodes marquées par [ClassCleanup] doivent respecter le schéma suivant pour être valides : 
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should not be specified if the class is 'sealed'.</source>
+        <target state="needs-review-translation">Les méthodes marquées par [ClassCleanup] doivent respecter le schéma suivant pour être valides : 
 - être « public » 
 - ne pas être 'statique'
 - ne pas être générique ni défini sur une classe générique

src/Analyzers/MSTest.Analyzers/xlf/Resources.it.xlf

@@ -109,8 +109,9 @@
 - return type should be 'void', 'Task' or 'ValueTask'
 - not be 'async void'
 - not be a special method (finalizer, operator...)
--'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'.</source>
-        <target state="translated">I metodi contrassegnati con [ClassCleanup] devono seguire il layout seguente per essere validi:
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should not be specified if the class is 'sealed'.</source>
+        <target state="needs-review-translation">I metodi contrassegnati con [ClassCleanup] devono seguire il layout seguente per essere validi:
 - devono essere "public" 
 - non devono essere "static"
 - non devono essere generici o definiti in una classe generica

src/Analyzers/MSTest.Analyzers/xlf/Resources.ja.xlf

@@ -109,8 +109,9 @@
 - return type should be 'void', 'Task' or 'ValueTask'
 - not be 'async void'
 - not be a special method (finalizer, operator...)
--'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'.</source>
-        <target state="translated">[ClassCleanup] でマークされたメソッドを有効にするには、次のレイアウトに従う必要があります: 
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should not be specified if the class is 'sealed'.</source>
+        <target state="needs-review-translation">[ClassCleanup] でマークされたメソッドを有効にするには、次のレイアウトに従う必要があります: 
 - 'public' です
 - 'static' ではありません
 - ジェネリックではなく、ジェネリック クラスでも定義されていない

src/Analyzers/MSTest.Analyzers/xlf/Resources.ko.xlf

@@ -109,8 +109,9 @@
 - return type should be 'void', 'Task' or 'ValueTask'
 - not be 'async void'
 - not be a special method (finalizer, operator...)
--'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'.</source>
-        <target state="translated">[ClassCleanup]으로 표시된 메서드가 유효하려면 다음 레이아웃을 따라야 합니다.
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should not be specified if the class is 'sealed'.</source>
+        <target state="needs-review-translation">[ClassCleanup]으로 표시된 메서드가 유효하려면 다음 레이아웃을 따라야 합니다.
 - 'public'이어야 함
 - 'static'이 아니어야 함
 - 제네릭이 아니거나 제네릭 클래스에 정의되지 않음

src/Analyzers/MSTest.Analyzers/xlf/Resources.pl.xlf

@@ -109,8 +109,9 @@
 - return type should be 'void', 'Task' or 'ValueTask'
 - not be 'async void'
 - not be a special method (finalizer, operator...)
--'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'.</source>
-        <target state="translated">Metody oznaczone za pomocą [ClassCleanup] powinny być zgodne z następującym układem, aby były prawidłowe:
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should not be specified if the class is 'sealed'.</source>
+        <target state="needs-review-translation">Metody oznaczone za pomocą [ClassCleanup] powinny być zgodne z następującym układem, aby były prawidłowe:
 — być „publiczne” 
 — nie być „statyczne”
 — nie być ogólne ani zdefiniowane w klasie ogólnej

src/Analyzers/MSTest.Analyzers/xlf/Resources.pt-BR.xlf

@@ -109,8 +109,9 @@
 - return type should be 'void', 'Task' or 'ValueTask'
 - not be 'async void'
 - not be a special method (finalizer, operator...)
--'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'.</source>
-        <target state="translated">Os métodos marcados com [ClassCleanup] devem seguir o seguinte layout para serem válidos:
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should not be specified if the class is 'sealed'.</source>
+        <target state="needs-review-translation">Os métodos marcados com [ClassCleanup] devem seguir o seguinte layout para serem válidos:
 - ser 'público' 
 - não ser 'estático'
 - não ser genérico nem definido em uma classe genérica

src/Analyzers/MSTest.Analyzers/xlf/Resources.ru.xlf

@@ -109,8 +109,9 @@
 - return type should be 'void', 'Task' or 'ValueTask'
 - not be 'async void'
 - not be a special method (finalizer, operator...)
--'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'.</source>
-        <target state="translated">Чтобы методы, отмеченные [ClassCleanup], были допустимыми, они должны соответствовать следующему макету:
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should not be specified if the class is 'sealed'.</source>
+        <target state="needs-review-translation">Чтобы методы, отмеченные [ClassCleanup], были допустимыми, они должны соответствовать следующему макету:
 – должны быть "общедоступными" 
 – не должны быть "статическими"
 – не должны быть универсальными и не должны определяться в универсальном классе

src/Analyzers/MSTest.Analyzers/xlf/Resources.tr.xlf

@@ -109,8 +109,9 @@
 - return type should be 'void', 'Task' or 'ValueTask'
 - not be 'async void'
 - not be a special method (finalizer, operator...)
--'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'.</source>
-        <target state="translated">[ClassCleanup] ile işaretlenen yöntemlerin geçerli olması için aşağıdaki düzeni takip etmesi gerekir:
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should not be specified if the class is 'sealed'.</source>
+        <target state="needs-review-translation">[ClassCleanup] ile işaretlenen yöntemlerin geçerli olması için aşağıdaki düzeni takip etmesi gerekir:
 - 'public' olmalı
 - 'static' olamaz
 - genel olamaz veya genel bir sınıf üzerinde tanımlanamaz

src/Analyzers/MSTest.Analyzers/xlf/Resources.zh-Hans.xlf

@@ -109,8 +109,9 @@
 - return type should be 'void', 'Task' or 'ValueTask'
 - not be 'async void'
 - not be a special method (finalizer, operator...)
--'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'.</source>
-        <target state="translated">标记有 [ClassCleanup] 的方法应遵循以下布局才会有效:
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should not be specified if the class is 'sealed'.</source>
+        <target state="needs-review-translation">标记有 [ClassCleanup] 的方法应遵循以下布局才会有效:
 - 是“public”
 - 不是“static”
 - 不是泛型的，也不是在泛型类上定义的

src/Analyzers/MSTest.Analyzers/xlf/Resources.zh-Hant.xlf

@@ -109,8 +109,9 @@
 - return type should be 'void', 'Task' or 'ValueTask'
 - not be 'async void'
 - not be a special method (finalizer, operator...)
--'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'.</source>
-        <target state="translated">標示 [ClassCleanup] 的方法應該遵循下列配置，才會有效:
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should not be specified if the class is 'sealed'.</source>
+        <target state="needs-review-translation">標示 [ClassCleanup] 的方法應該遵循下列配置，才會有效:
 - 為 'public' 
 - 不是 'static'
 - 不是泛型，也不是在泛型類別上定義

test/UnitTests/MSTest.Analyzers.UnitTests/ClassCleanupShouldBeValidAnalyzerTests.cs

@@ -627,4 +627,58 @@ public abstract class MyTestClass
 
         await VerifyCS.VerifyAnalyzerAsync(code);
     }
+
+    public async Task WhenClassCleanupIsOnSealedClassMarkedWithTestClass_AndWithInheritanceBehavior_Diagnostic()
+    {
+        string code = """
+            using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+            [TestClass]
+            public sealed class MyTestClass
+            {
+                [ClassCleanup(InheritanceBehavior.BeforeEachDerivedClass)]
+                public static void [|ClassCleanup|]()
+                {
+                }
+            }
+            """;
+
+        await VerifyCS.VerifyAnalyzerAsync(code);
+    }
+
+    public async Task WhenClassCleanupIsOnSealedClassMarkedWithTestClass_AndWithInheritanceBehaviorNone_NoDiagnostic()
+    {
+        string code = """
+            using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+            [TestClass]
+            public sealed class MyTestClass
+            {
+                [ClassCleanup(InheritanceBehavior.None)]
+                public static void ClassCleanup()
+                {
+                }
+            }
+            """;
+
+        await VerifyCS.VerifyAnalyzerAsync(code);
+    }
+
+    public async Task WhenClassCleanupIsOnSealedClassMarkedWithTestClass_WithDefaultInheritanceBehavior_NoDiagnostic()
+    {
+        string code = """
+            using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+            [TestClass]
+            public sealed class MyTestClass
+            {
+                [ClassCleanup]
+                public static void ClassCleanup()
+                {
+                }
+            }
+            """;
+
+        await VerifyCS.VerifyAnalyzerAsync(code);
+    }
 }