Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add codefix for MSTEST0020 #3798

Merged
merged 14 commits into from
Sep 10, 2024
Merged

Add codefix for MSTEST0020 #3798

merged 14 commits into from
Sep 10, 2024

Conversation

engyebrahim
Copy link
Member

fix: #3664

@engyebrahim
added initial code fix
c279673
@engyebrahim
fixed analyzer fixer
37b84af
@engyebrahim
update tests
653faa0
@engyebrahim
Merge branch 'main' into enji/code-fix
d5a9aa9 
# Conflicts:
#	src/Analyzers/MSTest.Analyzers.CodeFixes/CodeFixResources.Designer.cs
Evangelink
Evangelink reviewed Sep 10, 2024
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for:

  • the append is properly happening.
  • multiline code is moved properly (formatting is respected etc)

Also add some "invalid" scenario where you have 2 ctors (one parameterless and one with some parameters).

@Evangelink Evangelink merged commit ec6d4c6 into main Sep 10, 2024
6 checks passed
@Evangelink Evangelink deleted the enji/code-fix branch September 10, 2024 13:40
@engyebrahim engyebrahim mentioned this pull request Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink approved these changes

Assignees
No one assigned
Labels
Area: Analyzers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add codefix for MSTEST0020
2 participants
@engyebrahim @Evangelink