Add codefix for MSTEST0020

src/Analyzers/MSTest.Analyzers.CodeFixes/CodeFixResources.resx

@@ -153,4 +153,7 @@
   <data name="ReplaceWithTestCleanuFix" xml:space="preserve">
     <value>Replace 'Dispose' with a TestCleanup method</value>
   </data>
+  <data name="ReplaceWithConstructorFix" xml:space="preserve">
+    <value>Replace TestInitialize method with constructor</value>
+  </data>
 </root>

src/Analyzers/MSTest.Analyzers.CodeFixes/PreferConstructorOverTestInitializeFixer.cs

@@ -0,0 +1,104 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+using System.Collections.Immutable;
+using System.Composition;
+
+using Analyzer.Utilities;
+
+using Microsoft.CodeAnalysis;
+using Microsoft.CodeAnalysis.CodeActions;
+using Microsoft.CodeAnalysis.CodeFixes;
+using Microsoft.CodeAnalysis.CSharp;
+using Microsoft.CodeAnalysis.CSharp.Syntax;
+using Microsoft.CodeAnalysis.Editing;
+using Microsoft.CodeAnalysis.Text;
+
+using MSTest.Analyzers.Helpers;
+
+namespace MSTest.Analyzers;
+
+[ExportCodeFixProvider(LanguageNames.CSharp, Name = nameof(ClassInitializeShouldBeValidFixer))]
+[Shared]
+public sealed class PreferConstructorOverTestInitializeFixer : CodeFixProvider
+{
+    public override ImmutableArray<string> FixableDiagnosticIds { get; }
+        = ImmutableArray.Create(DiagnosticIds.PreferConstructorOverTestInitializeRuleId);
+
+    public override FixAllProvider GetFixAllProvider()
+        // See https://github.com/dotnet/roslyn/blob/main/docs/analyzers/FixAllProvider.md for more information on Fix All Providers
+        => WellKnownFixAllProviders.BatchFixer;
+
+    public override async Task RegisterCodeFixesAsync(CodeFixContext context)
+    {
+        SyntaxNode root = await context.Document.GetRequiredSyntaxRootAsync(context.CancellationToken).ConfigureAwait(false);
+
+        Diagnostic diagnostic = context.Diagnostics[0];
+        TextSpan diagnosticSpan = diagnostic.Location.SourceSpan;
+
+        SyntaxToken syntaxToken = root.FindToken(diagnosticSpan.Start);
+        if (syntaxToken.Parent is null)
+        {
+            return;
+        }
+
+        // Find the method declaration identified by the diagnostic.
+        MethodDeclarationSyntax methodDeclaration = syntaxToken.Parent.AncestorsAndSelf().OfType<MethodDeclarationSyntax>().FirstOrDefault();
+
+        context.RegisterCodeFix(
+            CodeAction.Create(
+                CodeFixResources.ReplaceWithConstructorFix,
+                c => ReplaceTestInitializeWithConstructorAsync(context.Document, methodDeclaration, c),
+                nameof(PreferConstructorOverTestInitializeFixer)),
+            diagnostic);
+    }
+
+    private static async Task<Document> ReplaceTestInitializeWithConstructorAsync(Document document, MethodDeclarationSyntax testInitializeMethod, CancellationToken cancellationToken)
+    {
+        DocumentEditor editor = await DocumentEditor.CreateAsync(document, cancellationToken).ConfigureAwait(false);
+
+        // Find the class containing the method
+        if (testInitializeMethod.Parent is ClassDeclarationSyntax containingClass)
+        {
+            ConstructorDeclarationSyntax existingConstructor = containingClass.Members
+                 .OfType<ConstructorDeclarationSyntax>()
+                 .FirstOrDefault();
+
+            // Move the body of the TestInitialize method
+            BlockSyntax? testInitializeBody = testInitializeMethod.Body;
+
+            if (existingConstructor != null)
+            {
+                StatementSyntax[]? testInitializeStatements = testInitializeBody?.Statements.ToArray();
+                ConstructorDeclarationSyntax newConstructor;
+
+                // If a constructor already exists, append the body of the TestInitialize method to it
+                if (existingConstructor.Body != null)
+                {
+                    BlockSyntax newConstructorBody = existingConstructor.Body.AddStatements(testInitializeStatements ?? Array.Empty<StatementSyntax>());
+                    newConstructor = existingConstructor.WithBody(newConstructorBody);
+                }
+                else
+                {
+                    newConstructor = existingConstructor.WithBody(testInitializeBody);
+                }
+
+                editor.ReplaceNode(existingConstructor, newConstructor);
+            }
+            else
+            {
+                // Create a new constructor with the TestInitialize body if one doesn't exist
+                ConstructorDeclarationSyntax constructor = SyntaxFactory.ConstructorDeclaration(containingClass.Identifier)
+                    .WithModifiers(SyntaxFactory.TokenList(SyntaxFactory.Token(SyntaxKind.PublicKeyword)))
+                    .WithBody(testInitializeBody);
+
+                editor.AddMember(containingClass, constructor);
+            }
+
+            // Remove the TestInitialize method
+            editor.RemoveNode(testInitializeMethod);
+        }
+
+        return editor.GetChangedDocument();
+    }
+}

src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.cs.xlf

@@ -32,6 +32,11 @@
         <target state="translated">Přidat [TestClass]</target>
         <note />
       </trans-unit>
+      <trans-unit id="ReplaceWithConstructorFix">
+        <source>Replace TestInitialize method with constructor</source>
+        <target state="new">Replace TestInitialize method with constructor</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ReplaceWithFailAssertionFix">
         <source>Replace the assertion with 'Assert.Fail()'</source>
         <target state="new">Replace the assertion with 'Assert.Fail()'</target>

src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.de.xlf

@@ -32,6 +32,11 @@
         <target state="translated">„[TestClass]“ hinzufügen</target>
         <note />
       </trans-unit>
+      <trans-unit id="ReplaceWithConstructorFix">
+        <source>Replace TestInitialize method with constructor</source>
+        <target state="new">Replace TestInitialize method with constructor</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ReplaceWithFailAssertionFix">
         <source>Replace the assertion with 'Assert.Fail()'</source>
         <target state="new">Replace the assertion with 'Assert.Fail()'</target>

src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.es.xlf

@@ -32,6 +32,11 @@
         <target state="translated">Agregar '[TestClass]'</target>
         <note />
       </trans-unit>
+      <trans-unit id="ReplaceWithConstructorFix">
+        <source>Replace TestInitialize method with constructor</source>
+        <target state="new">Replace TestInitialize method with constructor</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ReplaceWithFailAssertionFix">
         <source>Replace the assertion with 'Assert.Fail()'</source>
         <target state="new">Replace the assertion with 'Assert.Fail()'</target>

src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.fr.xlf

@@ -32,6 +32,11 @@
         <target state="translated">Ajouter « [TestClass] »</target>
         <note />
       </trans-unit>
+      <trans-unit id="ReplaceWithConstructorFix">
+        <source>Replace TestInitialize method with constructor</source>
+        <target state="new">Replace TestInitialize method with constructor</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ReplaceWithFailAssertionFix">
         <source>Replace the assertion with 'Assert.Fail()'</source>
         <target state="new">Replace the assertion with 'Assert.Fail()'</target>

src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.it.xlf

@@ -32,6 +32,11 @@
         <target state="translated">Aggiungi '[TestClass]'</target>
         <note />
       </trans-unit>
+      <trans-unit id="ReplaceWithConstructorFix">
+        <source>Replace TestInitialize method with constructor</source>
+        <target state="new">Replace TestInitialize method with constructor</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ReplaceWithFailAssertionFix">
         <source>Replace the assertion with 'Assert.Fail()'</source>
         <target state="new">Replace the assertion with 'Assert.Fail()'</target>

src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.ja.xlf

@@ -32,6 +32,11 @@
         <target state="translated">'[TestClass]' の追加</target>
         <note />
       </trans-unit>
+      <trans-unit id="ReplaceWithConstructorFix">
+        <source>Replace TestInitialize method with constructor</source>
+        <target state="new">Replace TestInitialize method with constructor</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ReplaceWithFailAssertionFix">
         <source>Replace the assertion with 'Assert.Fail()'</source>
         <target state="new">Replace the assertion with 'Assert.Fail()'</target>

src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.ko.xlf

@@ -32,6 +32,11 @@
         <target state="translated">'[TestClass]' 추가</target>
         <note />
       </trans-unit>
+      <trans-unit id="ReplaceWithConstructorFix">
+        <source>Replace TestInitialize method with constructor</source>
+        <target state="new">Replace TestInitialize method with constructor</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ReplaceWithFailAssertionFix">
         <source>Replace the assertion with 'Assert.Fail()'</source>
         <target state="new">Replace the assertion with 'Assert.Fail()'</target>

src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.pl.xlf

@@ -32,6 +32,11 @@
         <target state="translated">Dodaj element „[TestClass]”</target>
         <note />
       </trans-unit>
+      <trans-unit id="ReplaceWithConstructorFix">
+        <source>Replace TestInitialize method with constructor</source>
+        <target state="new">Replace TestInitialize method with constructor</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ReplaceWithFailAssertionFix">
         <source>Replace the assertion with 'Assert.Fail()'</source>
         <target state="new">Replace the assertion with 'Assert.Fail()'</target>

src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.pt-BR.xlf

@@ -32,6 +32,11 @@
         <target state="translated">Adicionar '[TestClass]'</target>
         <note />
       </trans-unit>
+      <trans-unit id="ReplaceWithConstructorFix">
+        <source>Replace TestInitialize method with constructor</source>
+        <target state="new">Replace TestInitialize method with constructor</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ReplaceWithFailAssertionFix">
         <source>Replace the assertion with 'Assert.Fail()'</source>
         <target state="new">Replace the assertion with 'Assert.Fail()'</target>

src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.ru.xlf

@@ -32,6 +32,11 @@
         <target state="translated">Добавить '[TestClass]'</target>
         <note />
       </trans-unit>
+      <trans-unit id="ReplaceWithConstructorFix">
+        <source>Replace TestInitialize method with constructor</source>
+        <target state="new">Replace TestInitialize method with constructor</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ReplaceWithFailAssertionFix">
         <source>Replace the assertion with 'Assert.Fail()'</source>
         <target state="new">Replace the assertion with 'Assert.Fail()'</target>

src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.tr.xlf

@@ -32,6 +32,11 @@
         <target state="translated">'[TestClass]' Ekle</target>
         <note />
       </trans-unit>
+      <trans-unit id="ReplaceWithConstructorFix">
+        <source>Replace TestInitialize method with constructor</source>
+        <target state="new">Replace TestInitialize method with constructor</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ReplaceWithFailAssertionFix">
         <source>Replace the assertion with 'Assert.Fail()'</source>
         <target state="new">Replace the assertion with 'Assert.Fail()'</target>

src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.zh-Hans.xlf

@@ -32,6 +32,11 @@
         <target state="translated">添加“[TestClass]”</target>
         <note />
       </trans-unit>
+      <trans-unit id="ReplaceWithConstructorFix">
+        <source>Replace TestInitialize method with constructor</source>
+        <target state="new">Replace TestInitialize method with constructor</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ReplaceWithFailAssertionFix">
         <source>Replace the assertion with 'Assert.Fail()'</source>
         <target state="new">Replace the assertion with 'Assert.Fail()'</target>

src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.zh-Hant.xlf

@@ -32,6 +32,11 @@
         <target state="translated">新增 '[TestClass]'</target>
         <note />
       </trans-unit>
+      <trans-unit id="ReplaceWithConstructorFix">
+        <source>Replace TestInitialize method with constructor</source>
+        <target state="new">Replace TestInitialize method with constructor</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ReplaceWithFailAssertionFix">
         <source>Replace the assertion with 'Assert.Fail()'</source>
         <target state="new">Replace the assertion with 'Assert.Fail()'</target>