Enable feeding a string from php to standard input #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks awesome, thanks! I only have a minor nitpick about coding style. If you could change that I'm happy to merge this. |
mikehaertl
reviewed
Dec 1, 2017
src/Command.php
Outdated
| @@ -322,10 +337,18 @@ public function execute() | |||
| 1 => array('pipe','w'), | |||
| 2 => array('pipe', $this->getIsWindows() ? 'a' : 'w'), | |||
| ); | |||
| if (isset($this->_stdIn)) { | |||
There was a problem hiding this comment.
I usually prefer !== null instead of isset() as I find it more clear. Could you maybe change that?
There was a problem hiding this comment.
Glad that you liked it!
I have changed this as requested.
mikehaertl
reviewed
Dec 1, 2017
src/Command.php
Outdated
| $process = proc_open($command, $descriptors, $pipes, $this->procCwd, $this->procEnv, $this->procOptions); | ||
|
|
||
| if (is_resource($process)) { | ||
|
|
||
| if(isset($this->_stdIn)) { |
|
Released 1.3.0 including this change. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes will make it possible to 'pipe' a string from php into the standard input stream of the command shell process.
Please consider this pr as I have found it quite useful.
Thank you for a very handy command wrapper!