-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable feeding a string from php to standard input #28
Merged
Merged
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,6 +59,11 @@ class Command | |
*/ | ||
public $locale; | ||
|
||
/** | ||
* @var string to pipe to standard input | ||
*/ | ||
protected $_stdIn; | ||
|
||
/** | ||
* @var string the command to execute | ||
*/ | ||
|
@@ -166,6 +171,16 @@ public function setCommand($command) | |
return $this; | ||
} | ||
|
||
/** | ||
* @param string $stdIn If set, the string will be piped to the command via standard input. | ||
* This enables the same functionality as piping on the command line. | ||
* @return static for method chaining | ||
*/ | ||
public function setStdIn($stdIn) { | ||
$this->_stdIn = $stdIn; | ||
return $this; | ||
} | ||
|
||
/** | ||
* @return string|null the command that was set through setCommand() or passed to the constructor. Null if none. | ||
*/ | ||
|
@@ -322,10 +337,18 @@ public function execute() | |
1 => array('pipe','w'), | ||
2 => array('pipe', $this->getIsWindows() ? 'a' : 'w'), | ||
); | ||
if (isset($this->_stdIn)) { | ||
$descriptors[0] = array('pipe', 'r'); | ||
} | ||
|
||
$process = proc_open($command, $descriptors, $pipes, $this->procCwd, $this->procEnv, $this->procOptions); | ||
|
||
if (is_resource($process)) { | ||
|
||
if(isset($this->_stdIn)) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here, see above. |
||
fwrite($pipes[0], $this->_stdIn); | ||
fclose($pipes[0]); | ||
} | ||
$this->_stdOut = stream_get_contents($pipes[1]); | ||
$this->_stdErr = stream_get_contents($pipes[2]); | ||
fclose($pipes[1]); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually prefer
!== null
instead ofisset()
as I find it more clear. Could you maybe change that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad that you liked it!
I have changed this as requested.