Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: lazy load promise related stuff #20766

Closed
wants to merge 2 commits into from
Closed

fs: lazy load promise related stuff #20766

wants to merge 2 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented May 16, 2018

These are commits that were originally in #20734....

Lazy load the promises impl and promise utility bindings.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label May 16, 2018
@jasnell
Copy link
Member Author

jasnell commented May 16, 2018

/cc @nodejs/fs

@jasnell
Copy link
Member Author

jasnell commented May 16, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/14899/

benjamingr
benjamingr approved these changes May 16, 2018
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual changes LGTM for cognitive overhead but I'd love to see a benchmark showing a measurable (even if small) impact.

I get why this would matter for require in userland but I'm not sure I understand why it would impact load times here.

@lpinca lpinca added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 17, 2018
@BridgeAR
Copy link
Member

@benjamingr

The actual changes LGTM for cognitive overhead but I'd love to see a benchmark showing a measurable (even if small) impact.

It is difficult to measure this with a small change like this alone. If you have a look at #20567 you can see that lazy loading does indeed significantly improve the performance. We still need snapshots but lazy loading is already a first good step and a good thing in general.

jasnell added a commit that referenced this pull request May 18, 2018
@jasnell
fs: lazy load the promises impl
11aea01 
PR-URL: #20766
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
jasnell added a commit that referenced this pull request May 18, 2018
@jasnell
fs: lazy load createPromise/promiseResolve
fa0cac5 
PR-URL: #20766
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@jasnell
Copy link
Member Author

jasnell commented May 18, 2018

Landed in 11aea01 and fa0cac5

@jasnell jasnell closed this May 18, 2018
MylesBorins pushed a commit that referenced this pull request May 22, 2018
@jasnell @MylesBorins
fs: lazy load the promises impl
2d28978 
PR-URL: #20766
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 22, 2018
@jasnell @MylesBorins
fs: lazy load createPromise/promiseResolve
9b43af3 
PR-URL: #20766
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@addaleax addaleax mentioned this pull request May 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@targos targos targos approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@JungMinu JungMinu JungMinu approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jasnell @BridgeAR @benjamingr @lpinca @TimothyGu @targos @joyeecheung @JungMinu @nodejs-github-bot