Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: lazy load promise related stuff #20766

Closed
wants to merge 2 commits into from
Closed

fs: lazy load promise related stuff #20766

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2494b80
fs: lazy load the promises impl
jasnell May 14, 2018
42859c8
fs: lazy load createPromise/promiseResolve
jasnell May 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions lib/fs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ const { S_IFIFO, S_IFLNK, S_IFMT, S_IFREG, S_IFSOCK } = constants;
const util = require('util');
const pathModule = require('path');
const { isUint8Array } = require('internal/util/types');
const { createPromise, promiseResolve } = process.binding('util');

const binding = process.binding('fs');
const fs = exports;
Expand All @@ -45,7 +44,6 @@ const { Readable, Writable } = require('stream');
const EventEmitter = require('events');
const { FSReqWrap, statValues, kFsStatsFieldsLength } = binding;
const { FSEvent } = process.binding('fs_event_wrap');
const promises = require('internal/fs/promises');
const internalFS = require('internal/fs/utils');
const { getPathFromURL } = require('internal/url');
const internalUtil = require('internal/util');
Expand Down Expand Up @@ -75,14 +73,18 @@ const {
validateUint32
} = require('internal/validators');

let warn = true;
// Lazy loaded
let promises;

let promisesWarn = true;

Object.defineProperty(fs, 'promises', {
configurable: true,
enumerable: false,
get() {
if (warn) {
warn = false;
if (promisesWarn) {
promises = require('internal/fs/promises');
promisesWarn = false;
process.emitWarning('The fs.promises API is experimental',
'ExperimentalWarning');
}
Expand Down Expand Up @@ -232,6 +234,7 @@ fs.exists = function(path, callback) {

Object.defineProperty(fs.exists, internalUtil.promisify.custom, {
value: (path) => {
const { createPromise, promiseResolve } = process.binding('util');
const promise = createPromise();
fs.exists(path, (exists) => promiseResolve(promise, exists));
return promise;
Expand Down